From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.204.112.148 with SMTP id w20cs347514bkp; Wed, 13 May 2009 18:52:50 -0700 (PDT) Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.140.148.20 as permitted sender) client-ip=10.140.148.20; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.140.148.20 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.140.148.20]) by 10.140.148.20 with SMTP id v20mr1899037rvd.19.1242265968952 (num_hops = 1); Wed, 13 May 2009 18:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received :mime-version:received:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding:reply-to :sender:precedence:x-google-loop:mailing-list:list-id:list-post :list-help:list-unsubscribe:x-beenthere-env:x-beenthere; bh=tD7Awrg0YVcgcP71cW23rCImU9hnx2kxhnuj1fX2ZOY=; b=FSqdG2L8FyjQJDlF12IVmEvUE4ojP90WFXuBmL5O1DcbXcXdl2gdB1Nbq7RoVfkfuP M++bD/1coTvggcA4PkGRY8HmSVp+1Y1QcWlynMMGatt2901CBMWlgOe+42N83rzSkZw3 Xc8GYYftYmrM7sixbFI86fwF42TzDZtyiTXmc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results :mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; b=JBG+GfeK0wP1BjX9LwwnierRNizq8J+C2bPL3jViaFLFg3pfnf/7HvwMkM+D8ulBuh evbpC20g+L8LabO1Et7FB7rbrMGzO+x+K8OQAT8WNN0AMdTUloLBRRB2Y+1fjg8s2j0D eDluIjWg0omK1rulhXlSeIBUeyUQjEZVCuiFo= Received: by 10.140.148.20 with SMTP id v20mr277471rvd.19.1242265968771; Wed, 13 May 2009 18:52:48 -0700 (PDT) Received: by 10.106.201.4 with SMTP id y4gr1317prf.0; Wed, 13 May 2009 18:52:48 -0700 (PDT) X-Sender: jeremy@bitsweat.net X-Apparently-To: rack-devel@googlegroups.com Received: by 10.100.138.17 with SMTP id l17mr919560and.24.1242265967861; Wed, 13 May 2009 18:52:47 -0700 (PDT) Return-Path: Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29]) by gmr-mx.google.com with ESMTP id 39si51923yxd.16.2009.05.13.18.52.47; Wed, 13 May 2009 18:52:47 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.44.29 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) client-ip=74.125.44.29; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 74.125.44.29 is neither permitted nor denied by best guess record for domain of jeremy@bitsweat.net) smtp.mail=jeremy@bitsweat.net Received: by yx-out-2324.google.com with SMTP id 8so573537yxm.71 for ; Wed, 13 May 2009 18:52:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.219.8 with SMTP id r8mr2414741ybg.330.1242265967641; Wed, 13 May 2009 18:52:47 -0700 (PDT) In-Reply-To: <20090430002127.7bd983f1@sigma.localdomain> References: <69a2885c0904290803j292d2c45j5a46d0e759b6272a@mail.gmail.com> <20090430002127.7bd983f1@sigma.localdomain> Date: Wed, 13 May 2009 18:52:47 -0700 Message-ID: <69a2885c0905131852h2ee62731o72337bec5490742e@mail.gmail.com> Subject: Re: Downsizing CommonLogger From: Jeremy Kemper To: rack-devel@googlegroups.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com On Wed, Apr 29, 2009 at 8:21 AM, Michael Fellinger wrote: > > On Wed, 29 Apr 2009 08:03:09 -0700 > Jeremy Kemper wrote: > >> CommonLogger calculates the content length itself. This duplicates >> work done by the app or ContentLength middleware. >> >> The middleware is simpler, faster, and generates less garbage per >> request by using the Content-Length header instead. >> >> Patch: >> http://github.com/jeremy/rack/commit/f9d38d9d866060be39192675adcc2efc19164c6f >> >> Best, >> jeremy > > +1 > I've also long wanted to extract the format string like you did... so +2 actually :) > > -- > ^ manveru > This change is still on deck. Attention upstream :) jeremy