From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.141.43.5 with SMTP id v5cs128449rvj; Mon, 22 Feb 2010 14:52:34 -0800 (PST) Received-SPF: pass (google.com: domain of 3sAqDSwYKCoku10tyv2u75v10.0y4npx-qr8ryt11tyrt41725.p1z@groups.bounces.google.com designates 10.151.93.5 as permitted sender) client-ip=10.151.93.5; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3sAqDSwYKCoku10tyv2u75v10.0y4npx-qr8ryt11tyrt41725.p1z@groups.bounces.google.com designates 10.151.93.5 as permitted sender) smtp.mail=3sAqDSwYKCoku10tyv2u75v10.0y4npx-qr8ryt11tyrt41725.p1z@groups.bounces.google.com; dkim=pass header.i=3sAqDSwYKCoku10tyv2u75v10.0y4npx-qr8ryt11tyrt41725.p1z@groups.bounces.google.com Received: from mr.google.com ([10.151.93.5]) by 10.151.93.5 with SMTP id v5mr1179077ybl.62.1266879153938 (num_hops = 1); Mon, 22 Feb 2010 14:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:mime-version:received:date :in-reply-to:x-ip:references:user-agent:x-http-useragent:message-id :subject:from:to:x-original-authentication-results:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:x-thread-url:x-message-url:sender:list-subscribe :list-unsubscribe:content-type:content-transfer-encoding; bh=eucOGfiHXTsCo5jg0kNPjEXFrjJcRmzR8Af5Wh401JI=; b=iFsaFWKHE1LkOdpjg+IpFEXU0mRT9UNi+Rviidf8ujTZavQTsnImpGiNNxo/m5Kicp 3+4TSZ+KP7V4+5EhXnpPV/who8u6jN8CS9MTjf6bq/hQSzIUxZjJGmhMZGqpW0TtFOwS kVOxcMPg2iIQuGt80OJ4wSYE/VO3KKsPbYxfY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:in-reply-to:x-ip :references:user-agent:x-http-useragent:message-id:subject:from:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :x-thread-url:x-message-url:sender:list-subscribe:list-unsubscribe :content-type:content-transfer-encoding; b=JtDwJgBCL13H02CqpFjbUT8F+NrLjpqAABPF/e4hP0ZQ0TlACOLHLjnxQcM5ddLdQX x8KlLp9/8BLveCpZhCMm+bvYGywIsZLHw7bybDByn1gG303Ghh/Te0l2G6BCeVPMZhnC IyCOt2c41+/Yd3XhzUkdApwVD1PTCq4spW+x4= Received: by 10.151.93.5 with SMTP id v5mr99413ybl.62.1266879152703; Mon, 22 Feb 2010 14:52:32 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.101.5.8 with SMTP id h8ls458247ani.3.p; Mon, 22 Feb 2010 14:52:30 -0800 (PST) Received: by 10.101.160.12 with SMTP id m12mr3357339ano.4.1266879150284; Mon, 22 Feb 2010 14:52:30 -0800 (PST) Received: by 10.101.160.12 with SMTP id m12mr3357338ano.4.1266879150256; Mon, 22 Feb 2010 14:52:30 -0800 (PST) Return-Path: Received: from mail-gx0-f193.google.com (mail-gx0-f193.google.com [209.85.217.193]) by gmr-mx.google.com with ESMTP id 11si638740gxk.9.2010.02.22.14.52.29; Mon, 22 Feb 2010 14:52:29 -0800 (PST) Received-SPF: pass (google.com: domain of hongli@phusion.nl designates 209.85.217.193 as permitted sender) client-ip=209.85.217.193; Received: by mail-gx0-f193.google.com with SMTP id 9so15207832gxk.7 for ; Mon, 22 Feb 2010 14:52:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.101.165.10 with SMTP id s10mr150165ano.19.1266879148895; Mon, 22 Feb 2010 14:52:28 -0800 (PST) Date: Mon, 22 Feb 2010 14:52:28 -0800 (PST) In-Reply-To: X-IP: 77.250.47.10 References: User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6,gzip(gfe),gzip(gfe) Message-ID: <63d3361b-53d7-4f4a-ac49-27ec3cdd2525@f42g2000yqn.googlegroups.com> Subject: Re: Adding #size to rack.input From: Hongli Lai To: Rack Development X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of hongli@phusion.nl designates 209.85.217.193 as permitted sender) smtp.mail=hongli@phusion.nl X-Original-Sender: hongli@phusion.nl Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/9c06163a4b13ccad X-Message-Url: http://groups.google.com/group/rack-devel/msg/a94d99b9b78f5efc Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Feb 22, 11:46=A0pm, Ryan Tomayko wrote: > On Mon, Feb 22, 2010 at 3:14 AM, Hongli Lai wrote: > > Hi Ryan. > > > Rack.input is already required to be rewindable, meaning the input has > > to be backed by a file or a StringIO at some point. It should be > > trivial for pretty much all Rack web servers to implement #size. Do > > you have any objections against including #size in the spec? > > > With kind regards, > > Hongli Lai > > That's a good point. Any objections to adding #size to the SPEC and > Rack::RewindableInput? I'd be happy to put the patches together. It should be noted that this request came from Chad Fowler who encountered the problem in the Gemcutter website. The existing code already assumes that #size is available, which is the case for e.g. Thin which exposes a StringIO or Tempfile as rack.input.