Re: Running rack tests on Windows (both 1.9.3 and 2.0.0)

[Tim Moore <timothy.m.moore@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

Luis,

I've submitted a pull request to rack that fixes a race condition when 
starting two servers simultaneously with the same pid file.

https://github.com/rack/rack/pull/505

I don't have easy access to a Windows machine to make sure that the fix 
works correctly there. Would you be able to advise?

Thanks,
Tim Moore

On Monday, November 12, 2012 12:20:55 AM UTC+11, Luis Lavena wrote:
>
> Hello,
>
> I've started to look into Rack (and its tests) on Windows just to ensure 
> things are running as much properly as possible.
>
> I found a few hardcoded values to temporary files (/tmp/rack_sendfile) 
> that is blocking spec_sendfile.rb from executing.
>
> Perhaps it will be good to use the system temporary directory instead?
>
> Beyond that, and without installing any particular handlers, rack tests 
> results in:
>
> ruby 1.9.3p327 (2012-11-10) [i386-mingw32]
> 583 tests, 1761 assertions, 4 failures, 2 errors
>
> ruby 2.0.0dev (2012-11-10 trunk 37612) [i386-mingw32]
> 583 tests, 1761 assertions, 5 failures, 2 errors
>
> ruby 2.0.0dev (2012-11-10 trunk 37612) [x64-mingw32]
> 583 tests, 1761 assertions, 5 failures, 2 errors
>
> See gist for full details:
>
> https://gist.github.com/4054864
>
> Do you think tests are incorrectly assuming details of the platform (test 
> is not prepared to run on Windows) or do you think the failures are 
> possible rack issues with Windows?
>
> How would you like to proceed? I wanted to get the conversation going 
> before invest more time on this.
>
> Thank you.
> --
> Luis Lavena
>
>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



[-- Attachment #2: Type: text/html, Size: 2618 bytes --]