From: Tim Moore <timothy.m.moore@gmail.com>
To: rack-devel@googlegroups.com
Subject: Re: Running rack tests on Windows (both 1.9.3 and 2.0.0)
Date: Wed, 30 Jan 2013 22:59:06 -0800 (PST) [thread overview]
Message-ID: <5af3a6f5-d939-47c3-9ebd-7937e6ccae24@googlegroups.com> (raw)
In-Reply-To: <0693588c-1dac-4b09-bd4f-5441a6143d49@googlegroups.com>
[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]
Luis,
I've submitted a pull request to rack that fixes a race condition when
starting two servers simultaneously with the same pid file.
https://github.com/rack/rack/pull/505
I don't have easy access to a Windows machine to make sure that the fix
works correctly there. Would you be able to advise?
Thanks,
Tim Moore
On Monday, November 12, 2012 12:20:55 AM UTC+11, Luis Lavena wrote:
>
> Hello,
>
> I've started to look into Rack (and its tests) on Windows just to ensure
> things are running as much properly as possible.
>
> I found a few hardcoded values to temporary files (/tmp/rack_sendfile)
> that is blocking spec_sendfile.rb from executing.
>
> Perhaps it will be good to use the system temporary directory instead?
>
> Beyond that, and without installing any particular handlers, rack tests
> results in:
>
> ruby 1.9.3p327 (2012-11-10) [i386-mingw32]
> 583 tests, 1761 assertions, 4 failures, 2 errors
>
> ruby 2.0.0dev (2012-11-10 trunk 37612) [i386-mingw32]
> 583 tests, 1761 assertions, 5 failures, 2 errors
>
> ruby 2.0.0dev (2012-11-10 trunk 37612) [x64-mingw32]
> 583 tests, 1761 assertions, 5 failures, 2 errors
>
> See gist for full details:
>
> https://gist.github.com/4054864
>
> Do you think tests are incorrectly assuming details of the platform (test
> is not prepared to run on Windows) or do you think the failures are
> possible rack issues with Windows?
>
> How would you like to proceed? I wanted to get the conversation going
> before invest more time on this.
>
> Thank you.
> --
> Luis Lavena
>
>
--
---
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[-- Attachment #2: Type: text/html, Size: 2618 bytes --]
next prev parent reply other threads:[~2013-01-31 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 13:20 Running rack tests on Windows (both 1.9.3 and 2.0.0) Luis Lavena
2012-11-11 18:59 ` James Tucker
2012-11-11 23:25 ` Konstantin Haase
2012-11-12 16:11 ` Luis Lavena
2013-01-31 6:59 ` Tim Moore [this message]
2013-02-07 2:02 ` James Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af3a6f5-d939-47c3-9ebd-7937e6ccae24@googlegroups.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).