From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.239.138.72 with SMTP id o8cs289109hbo; Wed, 5 May 2010 15:29:37 -0700 (PDT) Received-SPF: pass (google.com: domain of rack-devel+bncCKOb8oeaEhDL4offBBoEHjlN-A@googlegroups.com designates 10.150.247.2 as permitted sender) client-ip=10.150.247.2; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCKOb8oeaEhDL4offBBoEHjlN-A@googlegroups.com designates 10.150.247.2 as permitted sender) smtp.mail=rack-devel+bncCKOb8oeaEhDL4offBBoEHjlN-A@googlegroups.com; dkim=pass header.i=rack-devel+bncCKOb8oeaEhDL4offBBoEHjlN-A@googlegroups.com Received: from mr.google.com ([10.150.247.2]) by 10.150.247.2 with SMTP id u2mr5162150ybh.68.1273098572612 (num_hops = 1); Wed, 05 May 2010 15:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received:received-spf:received:mime-version:received :received:date:x-ip:user-agent:x-http-useragent:message-id:subject :from:to:x-original-authentication-results:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=bYZxufF6kuuT6hnyh6RBn+WgeYKUNVLpANn4gb4NfmU=; b=Yya7tAPcrSm70A2Sc4HqOMxN/NY5JKJHHNHPZZYjBe9VM/2Gy/K0hFr1u5iMXsNyn8 bf/AY7WSjbIjTR9A0ANGTiyHKYOG8caSTSDntQzJAdlFv75k9KLSvcFMfK5Kq1rMKiib NhBeMeSH4bP8HhU+R06Q6vcW2zBmxP4SKjEiw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:mime-version:date:x-ip:user-agent :x-http-useragent:message-id:subject:from:to :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; b=kv+uvuxPvBlZQQtjjarXycAo9TulQD3Tr0qvp7SjPthV7rbBLCEORc79T71v5g70Gu w1aFOx1FepQUMd1prSLhYW95xQJVIMT+vWLqrGD59aC3Ltf+GNqsSeTpV93EoXwNZQmC UIjht9thFCrEoC9+aue2U+Ifa+oQ2ZYMfCZfg= Received: by 10.150.247.2 with SMTP id u2mr1305588ybh.68.1273098571209; Wed, 05 May 2010 15:29:31 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.150.242.38 with SMTP id p38ls3699929ybh.6.p; Wed, 05 May 2010 15:29:30 -0700 (PDT) Received: by 10.150.127.23 with SMTP id z23mr174369ybc.7.1273098570302; Wed, 05 May 2010 15:29:30 -0700 (PDT) Received: by 10.101.8.40 with SMTP id l40mr3451021ani.9.1273075396591; Wed, 05 May 2010 09:03:16 -0700 (PDT) Received: by 10.101.8.40 with SMTP id l40mr3451020ani.9.1273075396557; Wed, 05 May 2010 09:03:16 -0700 (PDT) Return-Path: Received: from mail-yw0-f138.google.com (mail-yw0-f138.google.com [209.85.211.138]) by gmr-mx.google.com with ESMTP id b4si11280072anl.4.2010.05.05.09.03.16; Wed, 05 May 2010 09:03:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ogataken@gmail.com designates 209.85.211.138 as permitted sender) client-ip=209.85.211.138; Received: by ywh2 with SMTP id 2so4284475ywh.0 for ; Wed, 05 May 2010 09:03:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.134.39 with SMTP id l39mr580629ann.11.1273075396442; Wed, 05 May 2010 09:03:16 -0700 (PDT) Received: by y18g2000prn.googlegroups.com with HTTP; Wed, 5 May 2010 09:03:16 -0700 (PDT) Date: Wed, 5 May 2010 09:03:16 -0700 (PDT) X-IP: 124.41.71.191 User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.5.9-1.fc12 Firefox/3.5.9,gzip(gfe) Message-ID: <4c699dd9-5da3-45b4-88b1-e1e0001c4a44@y18g2000prn.googlegroups.com> Subject: Rack::CommonLogger does not receive Logger Instance. is this bug? From: sanemat To: Rack Development X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ogataken@gmail.com designates 209.85.211.138 as permitted sender) smtp.mail=ogataken@gmail.com X-Original-Sender: ogataken@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 hi. I'm sanemat. I use rest-client-components and rack-common-logger. It does not work, and I find problem in Rack::CommonLogger. Logger Instance does not have +write+ method. But Rack::CommonLogger's constructer require +write+ method in second parameter. ------ NoMethodError - undefined method `write' for #: /usr/lib/ruby/gems/1.8/gems/rack-1.1.0/lib/rack/commonlogger.rb:31:in `log' /usr/lib/ruby/gems/1.8/gems/rack-1.1.0/lib/rack/commonlogger.rb:20:in `call' ------ modify way I think: a. change Logger instance b. change commonlogger or anyway. so i try 'a' way like below, and it works. http://github.com/choonkeat/tweetstreamproxy/commit/ec82b0ac04b4f20ba33bf4f25dfb3f60e122d44c Logger.class_eval { alias :write :"<<" } unless Logger.instance_methods.include? "write" or 'b' way. like this. http://github.com/sanemat/rack/commit/865ab9655aa2aa226a9d21b8dfd39e001c9bdeb0 change method again from +write+ to +<<+. this changed one years ago. http://github.com/rack/rack/commit/761c6246e18b92752353c0f412976ded4a417dc5 which is better? I confuse this. i may be wrong but few people use Logger? thank you. rack 1.1.0 $ ruby -v ruby 1.8.7 (2009-12-24 patchlevel 248) [i686-linux] $ uname -a Linux fri 2.6.32.10-90.fc12.i686 #1 SMP Tue Mar 23 10:21:29 UTC 2010 i686 i686 i386 GNU/Linux -- sanemat