From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.239.138.72 with SMTP id o8cs21369hbo; Tue, 22 Jun 2010 05:10:04 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncCMqp3omTDRD7z4LhBBoEe317tQ@googlegroups.com designates 10.115.101.12 as permitted sender) client-ip=10.115.101.12; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCMqp3omTDRD7z4LhBBoEe317tQ@googlegroups.com designates 10.115.101.12 as permitted sender) smtp.mail=rack-devel+bncCMqp3omTDRD7z4LhBBoEe317tQ@googlegroups.com; dkim=pass header.i=rack-devel+bncCMqp3omTDRD7z4LhBBoEe317tQ@googlegroups.com Received: from mr.google.com ([10.115.101.12]) by 10.115.101.12 with SMTP id d12mr2447510wam.16.1277208596848 (num_hops = 1); Tue, 22 Jun 2010 05:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received :mime-version:received:received:date:x-ip:user-agent :x-http-useragent:message-id:subject:from:to:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=bybJJnSrUs2O16Hhay1/tI0rMfeGSCkadgRmO1uAmFc=; b=IPIOF7o6dNPA1hhu26EdigC2uc1SnWC5QELhFBpREz6V13/Hn26cjE/gIUC7TMYLwn KOFQ6O3cSoKq0w/4MdPSjWhlFW3eu/AlbUTo017Xr5vQ/6+kDkHMvITBH4aa+7LIaZ2L mkfMDk22mm0Vg3T09yt5snXQCScPOYO7O+lnc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:mime-version:date:x-ip:user-agent:x-http-useragent :message-id:subject:from:to:x-original-sender:reply-to:precedence :mailing-list:list-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; b=34d5z50pd1D9UrK8oukXftX2folNupheW/5Uy5n8dalpORQKEYxEzQsK+rYojs+hOP XamMxft/2ek842fzeqeVRPpAbGyWfkxOnNI/1UWDDkBUIqjjCChcEJcO4kB910Zqg24k RgWyU2rQbkMP5suZf2q23/sGEwDSPk6Pwl4GA= Received: by 10.115.101.12 with SMTP id d12mr482403wam.16.1277208571173; Tue, 22 Jun 2010 05:09:31 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.115.135.31 with SMTP id m31ls3301344wan.1.p; Tue, 22 Jun 2010 05:09:30 -0700 (PDT) Received: by 10.115.87.20 with SMTP id p20mr1109462wal.16.1277208570411; Tue, 22 Jun 2010 05:09:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.26.33 with SMTP id d33mr277163anj.79.1277208525377; Tue, 22 Jun 2010 05:08:45 -0700 (PDT) Received: by x27g2000yqb.googlegroups.com with HTTP; Tue, 22 Jun 2010 05:08:44 -0700 (PDT) Date: Tue, 22 Jun 2010 05:08:44 -0700 (PDT) X-IP: 139.112.1.135 User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_3; en-us) AppleWebKit/531.21.11 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10,gzip(gfe) Message-ID: <476e2835-02b3-4ebf-b798-ed502a804fed@x27g2000yqb.googlegroups.com> Subject: Bug in Rack::JSONP? From: =?ISO-8859-1?Q?Aslak_Helles=F8y?= To: Rack Development X-Original-Sender: aslak.hellesoy@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 Hi all, I'm using Rack::JSONP from rack-contrib in a Sinatra project. When I issue a GET request that's not JSON (and that doesn't set a Content- Type header, I get: NoMethodError: undefined method `include?' for nil:NilClass /Users/aslakhellesoy/.rvm/gems/ruby-1.8.7-p249@cukepatch/gems/rack- contrib-1.0.1/lib/rack/contrib/jsonp.rb:44:in `is_json?' Am I the only one running into this? Should I patch with: (headers['Content-Type'] || []).include?('application/json') in rack- contrib-1.0.1/lib/rack/contrib/jsonp.rb:44 Or is it better to patch rack to return an empty array instead of nil in #headers. I'm on rack 1.2.1 and Sinatra 1.0. Cheers, Aslak