[PATCH] Fix handling of multipart uploads where the filename includes a semicolon.

[PATCH] Fix handling of multipart uploads where the filename includes a semicolon.

[YoNoSoyTu]

Hello,

Rack 1.0.0 and the current Rack master branch includes a bug when
parsing a multipart upload, where one  of the filenames include a
semicolon ";". Currently the filename get truncated at the semicolon.
The fix uses the regular expression used by Ruby cgi.rb to parse
correctly the filename parameter when it includes the semicolon. A
test case is also included.

You can find the fix in my Github fork: <http://github.com/drodriguez/
rack/tree/fix_multipart_filename_parsing>. If you prefer a attached
patch file, or other format, please, let me know.

Regards,
Daniel Rodríguez Troitiño.

Re: [PATCH] Fix handling of multipart uploads where the filename includes a semicolon.

[Christian Neukirchen]

On Thu, Oct 8, 2009 at 9:00 AM, YoNoSoyTu <drodrigueztroitino@gmail.com> wrote:
>
> Hello,
>
> Rack 1.0.0 and the current Rack master branch includes a bug when
> parsing a multipart upload, where one  of the filenames include a
> semicolon ";". Currently the filename get truncated at the semicolon.
> The fix uses the regular expression used by Ruby cgi.rb to parse
> correctly the filename parameter when it includes the semicolon. A
> test case is also included.

I think this looks good, comments? Should go to rack-1.0 as well.

-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org