From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.86.99.8 with SMTP id w8cs29268fgb; Thu, 8 Oct 2009 01:25:21 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.150.44.14 as permitted sender) client-ip=10.150.44.14; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.150.44.14 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.150.44.14]) by 10.150.44.14 with SMTP id r14mr1209583ybr.28.1254990320939 (num_hops = 1); Thu, 08 Oct 2009 01:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :mime-version:content-type:content-transfer-encoding:received:date :x-ip:user-agent:x-http-useragent:message-id:subject:from:to :x-google-approved:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; bh=rPLwiRnM7I8sO627n4fOvT8kRdxXG0hbfm3m3Qb16zI=; b=SHvu+qs0RDQZUcj8xq9jPHMz51I0hxP2YYIdm6bQkWU2+9CMGOr7wIRQ/DcCTP6uOm IJcKF8dIChE7hIa2m10nQVLglFI7BnT6TRYXdN+LeUqYzSj6Ac0FfMhPdDeg4xMNt1Lu 3TVO8t+vOikLR9hhfUEYomBVBOWZ7ht2hYjgM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:mime-version:content-type :content-transfer-encoding:date:x-ip:user-agent:x-http-useragent :message-id:subject:from:to:x-google-approved:reply-to:sender :precedence:x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; b=AA1XwRJSvPgv8LvBl2TPpfQVqOY0c8ftrQF4+vY8zswH4gDzUYo1dRFGZCvmRaW6ep nEHCkTRNCAzlIEoao5dOLawE3JxGacLNyctaGHhtB+S7/oVQPHLWdJQKDiJLX2y0q2ct Z7CS6uMD0UqsBMvRBVtzXku077ReyRa7ngzKE= Received: by 10.150.44.14 with SMTP id r14mr109716ybr.28.1254990320878; Thu, 08 Oct 2009 01:25:20 -0700 (PDT) Received: by 10.176.145.38 with SMTP id s38gr1689yqd.0; Thu, 08 Oct 2009 01:25:15 -0700 (PDT) X-Sender: drodrigueztroitino@gmail.com X-Apparently-To: rack-devel@googlegroups.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Received: by 10.151.16.1 with SMTP id t1mr102798ybi.0.1254985253601; Thu, 08 Oct 2009 00:00:53 -0700 (PDT) Date: Thu, 8 Oct 2009 00:00:53 -0700 (PDT) X-IP: 89.55.193.28 User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_1; es-es) AppleWebKit/531.9 (KHTML, like Gecko) Version/4.0.3 Safari/531.9,gzip(gfe),gzip(gfe) Message-ID: <3543b06a-1f03-4d00-aeb3-cd65cd0ab67e@o21g2000vbl.googlegroups.com> Subject: [PATCH] Fix handling of multipart uploads where the filename includes a semicolon. From: YoNoSoyTu To: Rack Development X-Google-Approved: kenneth.kalmer@gmail.com via web at 2009-10-08 08:25:14 Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com Hello, Rack 1.0.0 and the current Rack master branch includes a bug when parsing a multipart upload, where one of the filenames include a semicolon ";". Currently the filename get truncated at the semicolon. The fix uses the regular expression used by Ruby cgi.rb to parse correctly the filename parameter when it includes the semicolon. A test case is also included. You can find the fix in my Github fork: . If you prefer a attached patch file, or other format, please, let me know. Regards, Daniel Rodr=EDguez Troiti=F1o.