From: YoNoSoyTu <drodrigueztroitino@gmail.com>
To: Rack Development <rack-devel@googlegroups.com>
Subject: [PATCH] Fix handling of multipart uploads where the filename includes a semicolon.
Date: Thu, 8 Oct 2009 00:00:53 -0700 (PDT) [thread overview]
Message-ID: <3543b06a-1f03-4d00-aeb3-cd65cd0ab67e@o21g2000vbl.googlegroups.com> (raw)
Hello,
Rack 1.0.0 and the current Rack master branch includes a bug when
parsing a multipart upload, where one of the filenames include a
semicolon ";". Currently the filename get truncated at the semicolon.
The fix uses the regular expression used by Ruby cgi.rb to parse
correctly the filename parameter when it includes the semicolon. A
test case is also included.
You can find the fix in my Github fork: <http://github.com/drodriguez/
rack/tree/fix_multipart_filename_parsing>. If you prefer a attached
patch file, or other format, please, let me know.
Regards,
Daniel Rodríguez Troitiño.
next reply other threads:[~2009-10-08 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 7:00 YoNoSoyTu [this message]
2009-10-08 11:31 ` [PATCH] Fix handling of multipart uploads where the filename includes a semicolon Christian Neukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3543b06a-1f03-4d00-aeb3-cd65cd0ab67e@o21g2000vbl.googlegroups.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).