From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.229.248.11 with SMTP id me11cs104915qcb; Sun, 10 Oct 2010 17:26:04 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncCI7j-tniEhCas8nlBBoEOUidoA@googlegroups.com designates 10.151.17.2 as permitted sender) client-ip=10.151.17.2; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncCI7j-tniEhCas8nlBBoEOUidoA@googlegroups.com designates 10.151.17.2 as permitted sender) smtp.mail=rack-devel+bncCI7j-tniEhCas8nlBBoEOUidoA@googlegroups.com; dkim=pass header.i=rack-devel+bncCI7j-tniEhCas8nlBBoEOUidoA@googlegroups.com Received: from mr.google.com ([10.151.17.2]) by 10.151.17.2 with SMTP id u2mr2496502ybi.52.1286756764186 (num_hops = 1); Sun, 10 Oct 2010 17:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received :mime-version:received:received:date:x-ip:user-agent :x-http-useragent:message-id:subject:from:to:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=WvttQnrZJwrvsD/3vZKshEJ+JL8RIUlB7kR5A18NoBk=; b=STgPhHP5h26DvummqW8X7r6+zdBE+oE28jfKyrt/QOAy7PALAi7nqYt3DySEtEiTRi BPop1Hvj0ipEyEiB505iRr1RC/Yv/4rHgSU4G6mFg0KqGi4ZxA/zoaI9MPmpTVDsgYzN K6SRgncYq1YGiB+5mbt9gQxIsBCCqWNZxDz0Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:mime-version:date:x-ip:user-agent:x-http-useragent :message-id:subject:from:to:x-original-sender:reply-to:precedence :mailing-list:list-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; b=lNT8rwXR4AShN1NgGr1lcwiMDVibNtthA84iRpsoJUyKjhtYZHYmMlMLzzmebnRreH dRi+ztVcdvNS1mus9aSy92JrSAgmVgQkPclP1ojYxgN0SPSmVUix89EPQ7jf9YEhbk/N 1MWekrLhGZxYkDkZdUFoiCMxSb1jzYtgqZUnw= Received: by 10.151.17.2 with SMTP id u2mr470913ybi.52.1286756762698; Sun, 10 Oct 2010 17:26:02 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.150.158.14 with SMTP id g14ls1054330ybe.7.p; Sun, 10 Oct 2010 17:26:02 -0700 (PDT) Received: by 10.150.203.5 with SMTP id a5mr1275947ybg.14.1286756761976; Sun, 10 Oct 2010 17:26:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.185.140 with SMTP id co12mr151777vcb.27.1286750438883; Sun, 10 Oct 2010 15:40:38 -0700 (PDT) Received: by y31g2000vbt.googlegroups.com with HTTP; Sun, 10 Oct 2010 15:40:38 -0700 (PDT) Date: Sun, 10 Oct 2010 15:40:38 -0700 (PDT) X-IP: 86.16.126.2 User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/7.0.544.0 Safari/534.10,gzip(gfe) Message-ID: <2bd5f0c4-e4ca-4141-b33f-61d8d674b4e3@y31g2000vbt.googlegroups.com> Subject: should Rack::Response delete Content-Length on status 204? From: Jerry West To: Rack Development X-Original-Sender: jerry.west@ntlworld.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rack-devel@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Type: text/plain; charset=ISO-8859-1 Rack::Response#finish deletes Content-Type from the header when status == 204. Should it not also delete Content-Length too? Rack::Lint certainly thinks so. And on that note should the code for #finish() not be if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i) rather than "if [204, 304].include?(status.to_i)" ... Thanks, Jerry