should Rack::Response delete Content-Length on status 204?

should Rack::Response delete Content-Length on status 204?

[Jerry West]

Rack::Response#finish deletes Content-Type from the header when status
== 204.

Should it not also delete Content-Length too?  Rack::Lint certainly
thinks so.

And on that note should the code for #finish() not be

if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i)

rather than "if [204, 304].include?(status.to_i)" ...

Thanks,
  Jerry

Re: should Rack::Response delete Content-Length on status 204?

[James Tucker]

Yes I think so, could you open an issue on github or a ticket on lighthouse? I will review soon.

Thank you!

On 10 Oct 2010, at 15:40, Jerry West wrote:

> Rack::Response#finish deletes Content-Type from the header when status
> == 204.
> 
> Should it not also delete Content-Length too?  Rack::Lint certainly
> thinks so.
> 
> And on that note should the code for #finish() not be
> 
> if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i)
> 
> rather than "if [204, 304].include?(status.to_i)" ...
> 
> Thanks,
>  Jerry

Re: should Rack::Response delete Content-Length on status 204?

[Jerry West]

Sorry, noob here - do you mean chneukirchen/rack or your fork?

On second thoughts, I'll do both, apologies for the duplication.

On Nov 7, 10:09 pm, James Tucker <jftuc...@gmail.com> wrote:
> Yes I think so, could you open an issue on github or a ticket on lighthouse? I will review soon.
>
> Thank you!
>
> On 10 Oct 2010, at 15:40, Jerry West wrote:
>
>
>
>
>
>
>
> > Rack::Response#finish deletes Content-Type from the header when status
> > == 204.
>
> > Should it not also delete Content-Length too?  Rack::Lint certainly
> > thinks so.
>
> > And on that note should the code for #finish() not be
>
> > if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i)
>
> > rather than "if [204, 304].include?(status.to_i)" ...
>
> > Thanks,
> >  Jerry

Re: should Rack::Response delete Content-Length on status 204?

[Jerry West]

No I won't - there are no issues on your fork so I've left it on
chneukirchen.

And I really shouldn't post before thinking it through...

Cheers.

On Nov 8, 11:00 pm, Jerry West <jerry.w...@ntlworld.com> wrote:
> Sorry, noob here - do you mean chneukirchen/rack or your fork?
>
> On second thoughts, I'll do both, apologies for the duplication.
>

Re: should Rack::Response delete Content-Length on status 204?

[James Tucker]

rack/rack

I'll cleanup sometime

On 8 Nov 2010, at 15:00, Jerry West wrote:

> Sorry, noob here - do you mean chneukirchen/rack or your fork?
> 
> On second thoughts, I'll do both, apologies for the duplication.
> 
> On Nov 7, 10:09 pm, James Tucker <jftuc...@gmail.com> wrote:
>> Yes I think so, could you open an issue on github or a ticket on lighthouse? I will review soon.
>> 
>> Thank you!
>> 
>> On 10 Oct 2010, at 15:40, Jerry West wrote:
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>>> Rack::Response#finish deletes Content-Type from the header when status
>>> == 204.
>> 
>>> Should it not also delete Content-Length too?  Rack::Lint certainly
>>> thinks so.
>> 
>>> And on that note should the code for #finish() not be
>> 
>>> if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i)
>> 
>>> rather than "if [204, 304].include?(status.to_i)" ...
>> 
>>> Thanks,
>>>  Jerry