Patches attached.<div><br></div><div>[1] tests_patch.diff -- Adds tests for the functionality of rackup</div><div>[2] rack_server_patch.diff -- Moves Rack::Server into a separate object</div><div><br clear="all">Yehuda Katz<br>

Developer | Engine Yard<br>(ph) 718.877.1325<br>
<br><br><div class="gmail_quote">2009/11/20 Yehuda Katz <span dir="ltr">&lt;<a href="mailto:wycats@gmail.com">wycats@gmail.com</a>&gt;</span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

Hey guys,<div><br></div><div>Carl and I spent a couple of day refactoring the code in bin/rackup into Rack::Server. The main motivation for this was to enable Rails to ditch our code in script/server and simply inherit from the requisite Rack code. I think the code improvement speaks for itself. In the process of this work, we also moved a few things out of Rackup into more usable locations, like Rack::Handler.default (to get the handler that Rack will use if none is specified) and Rack::Builder.parse_file (which we currently duplicate in ActionDispatch).</div>


<div><br></div><div>You can check out the changes at <a href="http://github.com/carllerche/rack" target="_blank">github.com/carllerche/rack</a>, and I have also attached a patch. In addition to converting the rackup binary to a class, we also wrote tests for each function of rackup, to be sure we wouldn&#39;t break anything in the refactor. As a result, this patch now has tests for rackup!</div>


<div><br clear="all">Yehuda Katz<br>Developer | Engine Yard<br>(ph) 718.877.1325<br>
</div>
</blockquote></div><br></div>