From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.142.191.1 with SMTP id o1cs131260wff; Fri, 20 Nov 2009 16:42:48 -0800 (PST) Received: from mr.google.com ([10.140.148.15]) by 10.140.148.15 with SMTP id v15mr1150597rvd.1.1258764167820 (num_hops = 1); Fri, 20 Nov 2009 16:42:47 -0800 (PST) Received: by 10.140.148.15 with SMTP id v15mr481712rvd.1.1258764166445; Fri, 20 Nov 2009 16:42:46 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.141.213.15 with SMTP id p15ls1004866rvq.3.p; Fri, 20 Nov 2009 16:42:45 -0800 (PST) Received: by 10.141.35.17 with SMTP id n17mr473661rvj.17.1258764165100; Fri, 20 Nov 2009 16:42:45 -0800 (PST) Received: by 10.141.35.17 with SMTP id n17mr473660rvj.17.1258764165074; Fri, 20 Nov 2009 16:42:45 -0800 (PST) Return-Path: Received: from mail-pw0-f58.google.com (mail-pw0-f58.google.com [209.85.160.58]) by gmr-mx.google.com with ESMTP id 16si535479pxi.9.2009.11.20.16.42.44; Fri, 20 Nov 2009 16:42:44 -0800 (PST) Received-SPF: pass (google.com: domain of wycats@gmail.com designates 209.85.160.58 as permitted sender) client-ip=209.85.160.58; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wycats@gmail.com designates 209.85.160.58 as permitted sender) smtp.mail=wycats@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by pwi21 with SMTP id 21so2474225pwi.17 for ; Fri, 20 Nov 2009 16:42:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.66.13 with SMTP id o13mr217324wfa.307.1258764163999; Fri, 20 Nov 2009 16:42:43 -0800 (PST) Date: Fri, 20 Nov 2009 16:42:43 -0800 Message-ID: <245fb4700911201642h56b9e639u20748e5a2117fbe8@mail.gmail.com> Subject: Rack::Server patch From: Yehuda Katz To: rack-devel Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/3eefabb1a33778df X-Message-Url: http://groups.google.com/group/rack-devel/msg/82df9315c5ae217d List-Unsubscribe: , List-Subscribe: , Content-Type: multipart/alternative; boundary=001636e0a510d9e7bc0478d6de9a --001636e0a510d9e7bc0478d6de9a Content-Type: text/plain; charset=ISO-8859-1 Hey guys, Carl and I spent a couple of day refactoring the code in bin/rackup into Rack::Server. The main motivation for this was to enable Rails to ditch our code in script/server and simply inherit from the requisite Rack code. I think the code improvement speaks for itself. In the process of this work, we also moved a few things out of Rackup into more usable locations, like Rack::Handler.default (to get the handler that Rack will use if none is specified) and Rack::Builder.parse_file (which we currently duplicate in ActionDispatch). You can check out the changes at github.com/carllerche/rack, and I have also attached a patch. In addition to converting the rackup binary to a class, we also wrote tests for each function of rackup, to be sure we wouldn't break anything in the refactor. As a result, this patch now has tests for rackup! Yehuda Katz Developer | Engine Yard (ph) 718.877.1325 --001636e0a510d9e7bc0478d6de9a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hey guys,

Carl and I spent a couple of day refactoring t= he code in bin/rackup into Rack::Server. The main motivation for this was t= o enable Rails to ditch our code in script/server and simply inherit from t= he requisite Rack code. I think the code improvement speaks for itself. In = the process of this work, we also moved a few things out of Rackup into mor= e usable locations, like Rack::Handler.default (to get the handler that Rac= k will use if none is specified) and Rack::Builder.parse_file (which we cur= rently duplicate in ActionDispatch).

You can check out the changes at github.com/carllerche/rack, and I have also att= ached a patch. In addition to converting the rackup binary to a class, we a= lso wrote tests for each function of rackup, to be sure we wouldn't bre= ak anything in the refactor. As a result, this patch now has tests for rack= up!

Yehuda Katz
Developer | Engine Yard
(ph) 718.8= 77.1325
--001636e0a510d9e7bc0478d6de9a--