From: Yehuda Katz <wycats@gmail.com>
To: rack-devel <rack-devel@googlegroups.com>
Subject: Rack::Server patch
Date: Fri, 20 Nov 2009 16:42:43 -0800 [thread overview]
Message-ID: <245fb4700911201642h56b9e639u20748e5a2117fbe8@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
Hey guys,
Carl and I spent a couple of day refactoring the code in bin/rackup into
Rack::Server. The main motivation for this was to enable Rails to ditch our
code in script/server and simply inherit from the requisite Rack code. I
think the code improvement speaks for itself. In the process of this work,
we also moved a few things out of Rackup into more usable locations, like
Rack::Handler.default (to get the handler that Rack will use if none is
specified) and Rack::Builder.parse_file (which we currently duplicate in
ActionDispatch).
You can check out the changes at github.com/carllerche/rack, and I have also
attached a patch. In addition to converting the rackup binary to a class, we
also wrote tests for each function of rackup, to be sure we wouldn't break
anything in the refactor. As a result, this patch now has tests for rackup!
Yehuda Katz
Developer | Engine Yard
(ph) 718.877.1325
[-- Attachment #2: Type: text/html, Size: 1047 bytes --]
next reply other threads:[~2009-11-21 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 0:42 Yehuda Katz [this message]
2009-11-21 0:46 ` Rack::Server patch Yehuda Katz
2009-11-21 0:52 ` Yehuda Katz
2009-11-21 2:10 ` Joshua Peek
2009-11-21 10:17 ` Christian Neukirchen
2009-11-21 10:18 ` Christian Neukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=245fb4700911201642h56b9e639u20748e5a2117fbe8@mail.gmail.com \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).