rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: James Tucker <jftucker@gmail.com>
To: rack-devel@googlegroups.com
Subject: Re: should Rack::Response delete Content-Length on status 204?
Date: Sun, 7 Nov 2010 14:09:24 -0800	[thread overview]
Message-ID: <234F3B33-10DE-499B-A01B-80C574ABA000@gmail.com> (raw)
In-Reply-To: <2bd5f0c4-e4ca-4141-b33f-61d8d674b4e3@y31g2000vbt.googlegroups.com>

Yes I think so, could you open an issue on github or a ticket on lighthouse? I will review soon.

Thank you!

On 10 Oct 2010, at 15:40, Jerry West wrote:

> Rack::Response#finish deletes Content-Type from the header when status
> == 204.
> 
> Should it not also delete Content-Length too?  Rack::Lint certainly
> thinks so.
> 
> And on that note should the code for #finish() not be
> 
> if Utils::STATUS_WITH_NO_ENTITY_BODY.include?(status.to_i)
> 
> rather than "if [204, 304].include?(status.to_i)" ...
> 
> Thanks,
>  Jerry

  reply	other threads:[~2010-11-07 22:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-10 22:40 should Rack::Response delete Content-Length on status 204? Jerry West
2010-11-07 22:09 ` James Tucker [this message]
2010-11-08 23:00   ` Jerry West
2010-11-08 23:07     ` Jerry West
2010-11-11  6:51     ` James Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=234F3B33-10DE-499B-A01B-80C574ABA000@gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).