From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.25.66.197 with SMTP id p188csp2277406lfa; Mon, 1 Feb 2016 01:53:05 -0800 (PST) X-Received: by 10.31.150.76 with SMTP id y73mr15115541vkd.84.1454320385759; Mon, 01 Feb 2016 01:53:05 -0800 (PST) Return-Path: Received: from mail-vk0-x238.google.com (mail-vk0-x238.google.com. [2607:f8b0:400c:c05::238]) by mx.google.com with ESMTPS id 128si8740423vkc.193.2016.02.01.01.53.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2016 01:53:05 -0800 (PST) Received-SPF: pass (google.com: domain of rack-devel+bncBD4PTDWJVIEBBAGWXS2QKGQEBDFWCSI@googlegroups.com designates 2607:f8b0:400c:c05::238 as permitted sender) client-ip=2607:f8b0:400c:c05::238; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rack-devel+bncBD4PTDWJVIEBBAGWXS2QKGQEBDFWCSI@googlegroups.com designates 2607:f8b0:400c:c05::238 as permitted sender) smtp.mailfrom=rack-devel+bncBD4PTDWJVIEBBAGWXS2QKGQEBDFWCSI@googlegroups.com; dkim=pass header.i=@googlegroups.com Received: by mail-vk0-x238.google.com with SMTP id e6sf38275472vkh.1; Mon, 01 Feb 2016 01:53:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe; bh=CJ+Khjb+/tpobmXTeoiyesi4d8DhdhCGTJiRW3REupE=; b=DUCFwm9FsSnCtp48yalobMNm0rTL6p2NsA4p7+Ia6ixVNqVlekxkMgJI/U9S8EoEqu JH5af6JmZ2dFyPB5DH8NhHADhqZLAzPwfxnjGh8PV5up1rEedRnCWHAGvLMWdZKwytt6 xXum1UxgLKVqnM3/ebzzLWBMDT8E9HZ4hSFaF+Q6D3MXkMoh/QFioRE4H/U0nvoyPNig iKxBpkm8jVybAcFXxtyc7AZZouTJHfvGr1ynUCXhNTdcgkmWEafVTkh380BzEIIBVNF6 3Kfp7Ltniqghsq/tM84pb8GzyGdTlc0ZRHDgJnIU2yRzjCIrWKRiMWC0ifonHnDOjbHc wnJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe; bh=CJ+Khjb+/tpobmXTeoiyesi4d8DhdhCGTJiRW3REupE=; b=NTqvFC0smxfABUJctwLB4akvGqVDhbkig1vukgTQ40hq/l8TORHdM7dsVVNBKvLZHL mmN9jJAnyBnQQ7UxVc0E8Ar6rjIfKcb1OpQImNgH+2B3t15vcVNMD2gdK3z8qmVC+PXK Ngr7jT+I1DnGPSJYqKMEU+M/hXhTE0cwXCqJw+/e1MGtbLszI67U4TRREiAerFBYCH+N 7mRpGpSzVgeom1W0+UV+GFbfNuq75+OnWpZoIwtiDSBPlyxA0ftRFjsFPqevui0FsWfb NpFB0gy07ImMTt+Pepb0yGTYJa/429yswg8iIdup00oBly+kCD+QjzbIJsyNm/UmLH/3 oNfg== X-Gm-Message-State: AG10YOQiFnvzZSY521FwvZHsCdSaLJ3TCS7NXnquXtdUe31Np9X6y1SAkowZtG8Wx4SNnQ== X-Received: by 10.50.33.8 with SMTP id n8mr157910igi.9.1454320385398; Mon, 01 Feb 2016 01:53:05 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.107.135.37 with SMTP id j37ls181908iod.32.gmail; Mon, 01 Feb 2016 01:53:04 -0800 (PST) X-Received: by 10.50.142.105 with SMTP id rv9mr11574340igb.10.1454320384842; Mon, 01 Feb 2016 01:53:04 -0800 (PST) Received: from dcvr.yhbt.net (dcvr.yhbt.net. [64.71.152.64]) by gmr-mx.google.com with ESMTP id 12si468537pfb.1.2016.02.01.01.53.04 for ; Mon, 01 Feb 2016 01:53:04 -0800 (PST) Received-SPF: neutral (google.com: 64.71.152.64 is neither permitted nor denied by best guess record for domain of e@80x24.org) client-ip=64.71.152.64; Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4948F1F612; Mon, 1 Feb 2016 09:53:04 +0000 (UTC) Date: Mon, 1 Feb 2016 09:53:03 +0000 From: Eric Wong To: rack-devel@googlegroups.com Subject: Re: configurable trusted proxies? Message-ID: <20160201095303.GA14608@dcvr.yhbt.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline In-Reply-To: X-Original-Sender: e@80x24.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 64.71.152.64 is neither permitted nor denied by best guess record for domain of e@80x24.org) smtp.mailfrom=e@80x24.org Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rack-devel@googlegroups.com X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , "S. Brent Faulkner" wrote: > Hi all... wondering if anyone is willing to review and/or discuss the idea > of configurable trusted proxies for Rack > ? https://github.com/rack/rack/pull/1001 I'm not sure why you put the directive inside Rack::Utils instead of Rack::Request where it is the only user. I suspect there's Rack::Utils users who do not use Rack::Request. Not sure if the extra Array creation and block invocation makes a meaningful performance difference for anyone. Otherwise I guess it's fine (not that I can merge your change). Note: I reviewed by adding the following line to my .git/config at the remote configured for git://github.com/rack/rack.git fetch = +refs/pull/*:refs/remotes/pull/* Then "git fetch", and "git log -p --color-words pull/1001/head" This was following commit 13397c7963b30f1d05e316d4de1930a6f81abf38 The "--color-words" switch made the test/spec_request.rb changes much more readable. (I don't use proprietary APIs or run JavaScript) -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.