From: Eric Wong <e@80x24.org>
To: rack-devel@googlegroups.com
Subject: Re: configurable trusted proxies?
Date: Mon, 1 Feb 2016 09:53:03 +0000 [thread overview]
Message-ID: <20160201095303.GA14608@dcvr.yhbt.net> (raw)
In-Reply-To: <bb8f9f3f-0d7a-4211-91f7-d8ac63a5115c@googlegroups.com>
"S. Brent Faulkner" <sbfaulkner@gmail.com> wrote:
> Hi all... wondering if anyone is willing to review and/or discuss the idea
> of configurable trusted proxies for Rack
> ? https://github.com/rack/rack/pull/1001
I'm not sure why you put the directive inside Rack::Utils
instead of Rack::Request where it is the only user.
I suspect there's Rack::Utils users who do not use Rack::Request.
Not sure if the extra Array creation and block invocation makes
a meaningful performance difference for anyone.
Otherwise I guess it's fine (not that I can merge your change).
Note: I reviewed by adding the following line to my .git/config
at the remote configured for git://github.com/rack/rack.git
fetch = +refs/pull/*:refs/remotes/pull/*
Then "git fetch", and "git log -p --color-words pull/1001/head"
This was following commit 13397c7963b30f1d05e316d4de1930a6f81abf38
The "--color-words" switch made the test/spec_request.rb changes
much more readable.
(I don't use proprietary APIs or run JavaScript)
--
---
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-01 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 15:40 configurable trusted proxies? S. Brent Faulkner
2016-02-01 9:53 ` Eric Wong [this message]
2016-02-02 2:00 ` S. Brent Faulkner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201095303.GA14608@dcvr.yhbt.net \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).