From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.25.18.86 with SMTP id h83csp764528lfi; Fri, 8 Jan 2016 14:37:33 -0800 (PST) X-Received: by 10.107.136.222 with SMTP id s91mr40469847ioi.20.1452292653594; Fri, 08 Jan 2016 14:37:33 -0800 (PST) Return-Path: Received: from mail-ig0-x23c.google.com (mail-ig0-x23c.google.com. [2607:f8b0:4001:c05::23c]) by mx.google.com with ESMTPS id e10si226396igy.5.2016.01.08.14.37.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 14:37:33 -0800 (PST) Received-SPF: pass (google.com: domain of rack-devel+bncBD4PTDWJVIEBBLHUYC2AKGQELPQW2QQ@googlegroups.com designates 2607:f8b0:4001:c05::23c as permitted sender) client-ip=2607:f8b0:4001:c05::23c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rack-devel+bncBD4PTDWJVIEBBLHUYC2AKGQELPQW2QQ@googlegroups.com designates 2607:f8b0:4001:c05::23c as permitted sender) smtp.mailfrom=rack-devel+bncBD4PTDWJVIEBBLHUYC2AKGQELPQW2QQ@googlegroups.com; dkim=pass header.i=@googlegroups.com Received: by mail-ig0-x23c.google.com with SMTP id rs1sf26269242igb.0; Fri, 08 Jan 2016 14:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe; bh=U2F8Ox7ZKFLh3LOdvI7G9e/Z78tq2jiY3507fmdOAbg=; b=Z7vfpNACpjt/XeE0o3RihB7NeE3kQ97lH2Rc4qvXal993My4J2Ne2XNODMMsGLLpHH WfIKZRh+M6MORxodl1YVJZl46epnDOY3oKqYjuz8xXzXcNoosD+Ud0FUlGbO2BmJNxzq NEWSwHM5xkI6m4Ae9YjDAc6fN6KwDwcSPdHYZATebUqrwuX16Ua+Y6t130ATgUxLjHSj 9hrrTHk2Df9CoAroqD0nU0NvTNUdfKdKeeORA1/1MsOd8sDN2w6PTChiVKAMll1scZn8 ad9RuERQNNVJXx8mFYwcZZVPeF9e8b9iMcuq1j8GU5JdHc222NI8AGue3guAHexjFs97 A2/A== X-Received: by 10.50.118.7 with SMTP id ki7mr57335igb.7.1452292653232; Fri, 08 Jan 2016 14:37:33 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.107.137.89 with SMTP id l86ls5275597iod.64.gmail; Fri, 08 Jan 2016 14:37:32 -0800 (PST) X-Received: by 10.50.57.114 with SMTP id h18mr1386840igq.12.1452292652725; Fri, 08 Jan 2016 14:37:32 -0800 (PST) Received: from dcvr.yhbt.net (dcvr.yhbt.net. [64.71.152.64]) by gmr-mx.google.com with ESMTP id k67si271447pfb.0.2016.01.08.14.37.32 for ; Fri, 08 Jan 2016 14:37:32 -0800 (PST) Received-SPF: neutral (google.com: 64.71.152.64 is neither permitted nor denied by best guess record for domain of e@80x24.org) client-ip=64.71.152.64; Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2EEE72021D; Fri, 8 Jan 2016 22:37:32 +0000 (UTC) Date: Fri, 8 Jan 2016 22:37:32 +0000 From: Eric Wong To: Aaron Patterson Cc: rack-devel@googlegroups.com, Adam Duke , unicorn-public@bogomips.org Subject: Re: [PATCH] limit rack version for ruby compatibility Message-ID: <20160108223732.GA28771@dcvr.yhbt.net> References: <20160108191807.GA30703@dcvr.yhbt.net> <20160108215046.GA36373@TC.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline In-Reply-To: <20160108215046.GA36373@TC.local> X-Original-Sender: e@80x24.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 64.71.152.64 is neither permitted nor denied by best guess record for domain of e@80x24.org) smtp.mailfrom=e@80x24.org Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rack-devel@googlegroups.com X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Aaron Patterson wrote: > The main reason I bumped it up to Ruby 2.2.x is because that will be the > minimum version of Ruby I'll be stuck with throughout Rack 2.x's > lifetime. IOW, I can't drop Ruby versions in anything but a major > release so I'm being conservative and only going with the latest (at the > time that was 2.2). > > I could be convinced to bring down the version number, but I'd like to > know why first. :) Because other people are _always_ slow to upgrade :) However, I suppose it's fine to bring the requirement up with a major version bump of Rack. I don't want to burden you with old cruft, either. unicorn may also be able to drop the dependency on rack by lazy loading: * Rack::Utils::HTTP_STATUS_CODES is the main thing we use from Rack at runtime; and unicorn would actually function fine if the hash were empty; HTTP status lines would just be short and non-descriptive. * The Rack::Builder dependency can be optional, even. Fwiw, I plan to support Rack 1.x and Ruby 1.9.3 under unicorn for a few more years because of LTS distros. New versions take priority, of course. > On Fri, Jan 08, 2016 at 07:18:07PM +0000, Eric Wong wrote: > > Adam Duke wrote: > > > +++ b/unicorn.gemspec > > > @@ -35,7 +35,11 @@ > > > # up/downgrade to any other version, the Rack dependency may be > > > # commented out. Nevertheless, upgrading to Rails 2.3.4 or later is > > > # *strongly* recommended for security reasons. > > > - s.add_dependency(%q) > > > + if RUBY_VERSION < '2.2.2' > > > + s.add_dependency(%q, '~> 1.6.4') > > > + else > > > + s.add_dependency(%q) > > > + end > > > > Interesting, I built a gem with RubyGems 2.5.1 and this conditional > > was preserved in the gemspec. I tried this in the past (2009/2010?) > > and any conditionals written like this got clobbered in the final > > gemspec. > > I wonder if that's true even after you upload to rubygems.org. I'd > guess it's not true as they don't want to support arbitrary ruby code > for specs. Ah, you're right. I was looking at the gemspec which is distributed with the gem source and not the regenerated gemspec which RubyGems actually uses. So yeah, it looks like Adam's patch only affects the gem build process. -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.