From: Aaron Patterson <tenderlove@ruby-lang.org>
To: Aaron Patterson <tenderlove@ruby-lang.org>
Cc: rack-devel@googlegroups.com, Adam Duke <adamduke@twitter.com>,
unicorn-public@bogomips.org
Subject: Re: [PATCH] limit rack version for ruby compatibility
Date: Fri, 8 Jan 2016 13:56:59 -0800 [thread overview]
Message-ID: <20160108215659.GA36442@TC.local> (raw)
In-Reply-To: <20160108215046.GA36373@TC.local>
[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]
On Fri, Jan 08, 2016 at 01:50:46PM -0800, Aaron Patterson wrote:
> On Fri, Jan 08, 2016 at 07:18:07PM +0000, Eric Wong wrote:
> > Adam Duke <adamduke@twitter.com> wrote:
> > > From: Adam Duke <adam.v.duke@gmail.com>
> > > Date: Fri, 8 Jan 2016 13:06:31 -0500
> > > Subject: [PATCH] limit rack version for ruby compatibility
> > >
> > > rack introduced a dependency on ruby 2.2.2 or greater in
> > > https://github.com/rack/rack/commit/771d94e5dbe53058160a1f8a4cc56384c1d2a048
> >
> > Cc-ing rack-devel + Aaron
> >
> > Yikes! ruby-core still supports Ruby 2.1 and possibly even 2.0.0
> >
> > And there doesn't seem to be any documentation on why Ruby 2.2.x
> > is needed in the first place for rack.git
> > commit a2fe30a5e70371c89c1b29fdc2dc5f8027bc5fe6
> >
> > http://bogomips.org/mirrors/rack.git/patch?id=a2fe30a5e70371c8
> >
> > Aaron?
>
> The main reason I bumped it up to Ruby 2.2.x is because that will be the
> minimum version of Ruby I'll be stuck with throughout Rack 2.x's
> lifetime. IOW, I can't drop Ruby versions in anything but a major
> release so I'm being conservative and only going with the latest (at the
> time that was 2.2).
>
> I could be convinced to bring down the version number, but I'd like to
> know why first. :)
Oh, I forgot to mention that I don't mind eliminating the Ruby version
requirement as long as we put something in the README that says we only
guarantee it works on 2.2.x and up. Older versions could be "best
effort". I'm just afraid to do something like that because I really
don't want to maintain 1.8 and 1.9 baggage (for example). I used the
gemspec to clearly announce the Ruby versions I actually test with.
--
Aaron Patterson
http://tenderlovemaking.com/
--
---
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-01-08 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACj6Wog0=R6Wsh1U5SFE6r1BdWBr4Loe+GM6UKdObSALwAj9JQ@mail.gmail.com>
2016-01-08 19:18 ` [PATCH] limit rack version for ruby compatibility Eric Wong
2016-01-08 21:50 ` Aaron Patterson
2016-01-08 21:56 ` Aaron Patterson [this message]
[not found] ` <CACj6WohuY65xCNVRwrA4ODrj1NcsMNaDBw8ykxJ6YBAhZ4ZU4Q@mail.gmail.com>
2016-01-08 22:17 ` Aaron Patterson
2016-01-08 22:37 ` Eric Wong
2016-01-08 23:19 ` Aaron Patterson
[not found] ` <CACj6Wog+1rqEaW1R1G0eKEZuz7vNVUC51Qh7q7Z1tKpzRrybKw@mail.gmail.com>
2016-01-21 20:12 ` Eric Wong
2016-01-21 22:09 ` Aaron Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108215659.GA36442@TC.local \
--to=rack-devel@googlegroups.com \
--cc=adamduke@twitter.com \
--cc=tenderlove@ruby-lang.org \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).