From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.25.18.86 with SMTP id h83csp745157lfi; Fri, 8 Jan 2016 13:50:51 -0800 (PST) X-Received: by 10.107.132.97 with SMTP id g94mr91914557iod.159.1452289851005; Fri, 08 Jan 2016 13:50:51 -0800 (PST) Return-Path: Received: from mail-io0-x23f.google.com (mail-io0-x23f.google.com. [2607:f8b0:4001:c06::23f]) by mx.google.com with ESMTPS id c25si217805ioj.190.2016.01.08.13.50.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 13:50:50 -0800 (PST) Received-SPF: pass (google.com: domain of rack-devel+bncBDI5L5VXVAHBBOO6YC2AKGQEJYYC5NY@googlegroups.com designates 2607:f8b0:4001:c06::23f as permitted sender) client-ip=2607:f8b0:4001:c06::23f; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rack-devel+bncBDI5L5VXVAHBBOO6YC2AKGQEJYYC5NY@googlegroups.com designates 2607:f8b0:4001:c06::23f as permitted sender) smtp.mailfrom=rack-devel+bncBDI5L5VXVAHBBOO6YC2AKGQEJYYC5NY@googlegroups.com; dkim=pass header.i=@googlegroups.com Received: by mail-io0-x23f.google.com with SMTP id q21sf4915437iod.1; Fri, 08 Jan 2016 13:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=Ok7zLuviP7ZOzAkbq0y6r16drUkHqEzDyszQkitXgWE=; b=tIQIifOlQIrX2yeNvRNflkWedishpCzmxMUPHcjMjZorjsDMo1+GnBXVX1cOy/L1uH z1nTtxsYNghT0es/SHrZnHZJfBCFBo18vU/1GguwMJ3Dl8om0+jMoW7DYUQPMvvZvmGQ B7bT8ItJxWXZM/Cj8ObtUv9VTClHK9pPVesQmJF+0dPMB2oiUwtUPl25MWcML4EzF9HX OYwAFdEc4HGFcDdIS3nseNsVgZ1kNBJG8szuAzSSxB6uvhUGt1oe9dpF7QCPbtGUWEOs 2/oyhbzB+i5F+zErlPagV4H3CWi/ozsJhDuchdOJ9aJZwgCSf2icrf0gYK4dO8X9hPpP iFYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Ok7zLuviP7ZOzAkbq0y6r16drUkHqEzDyszQkitXgWE=; b=E0fp3A6jTkLSDNfx/Rvy+BtDqQTBSNX1X7kbaWnhYhx215gQBIUP2CPoVlCukOjrB7 VwcKqbAt06+I+4e479TlSOBssjY067Bp8LhwuMGw1MNsWBRdZ++A51X99Ub4yZgT740D ZSopUYMx7HCqw+x44pMA8d2lOyseZ25nCfE5/0yV7K8TET7yonDxMwa+JNze7giFGC+d HSG8I3UUR8GSGGi5seDFBaq3oL4I740eSyI8JrWgSA1GoJIQtoSfSklrwB+irkyhw/E3 qrSHKBbOKPYl2fspHEl4LWJZhNzG61VkPrUcihgf5w11QHDE/Y5RtBdTfTPSXR35to87 n+Xw== X-Received: by 10.182.28.129 with SMTP id b1mr1080914obh.4.1452289850471; Fri, 08 Jan 2016 13:50:50 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.182.104.3 with SMTP id ga3ls263315obb.18.gmail; Fri, 08 Jan 2016 13:50:49 -0800 (PST) X-Received: by 10.182.33.102 with SMTP id q6mr90862481obi.11.1452289849609; Fri, 08 Jan 2016 13:50:49 -0800 (PST) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com. [2607:f8b0:400e:c03::22a]) by gmr-mx.google.com with ESMTPS id jj4si10846380pac.2.2016.01.08.13.50.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 13:50:49 -0800 (PST) Received-SPF: neutral (google.com: 2607:f8b0:400e:c03::22a is neither permitted nor denied by best guess record for domain of aaron@tenderlovemaking.com) client-ip=2607:f8b0:400e:c03::22a; Received: by mail-pa0-x22a.google.com with SMTP id ho8so27655802pac.2 for ; Fri, 08 Jan 2016 13:50:49 -0800 (PST) X-Gm-Message-State: ALoCoQmD0q2+0LvJJLs6HDuwpovGLx7U8pMT3Ep3Qd82XzfdQ4msKIdvn0duKy5Zc4t8sIcIarcecDPoYVEM1bLrg5sX9Nc+Vw== X-Received: by 10.66.222.101 with SMTP id ql5mr162721146pac.144.1452289849295; Fri, 08 Jan 2016 13:50:49 -0800 (PST) Received: from TC.local (c-24-56-229-227.customer.broadstripe.net. [24.56.229.227]) by smtp.gmail.com with ESMTPSA id ud10sm169280800pab.27.2016.01.08.13.50.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 13:50:48 -0800 (PST) Sender: rack-devel@googlegroups.com Date: Fri, 8 Jan 2016 13:50:46 -0800 From: Aaron Patterson To: rack-devel@googlegroups.com Cc: Adam Duke , unicorn-public@bogomips.org Subject: Re: [PATCH] limit rack version for ruby compatibility Message-ID: <20160108215046.GA36373@TC.local> References: <20160108191807.GA30703@dcvr.yhbt.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <20160108191807.GA30703@dcvr.yhbt.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Original-Sender: aaron@tenderlovemaking.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2607:f8b0:400e:c03::22a is neither permitted nor denied by best guess record for domain of aaron@tenderlovemaking.com) smtp.mailfrom=aaron@tenderlovemaking.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rack-devel@googlegroups.com X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Fri, Jan 08, 2016 at 07:18:07PM +0000, Eric Wong wrote: > Adam Duke wrote: > > From: Adam Duke > > Date: Fri, 8 Jan 2016 13:06:31 -0500 > > Subject: [PATCH] limit rack version for ruby compatibility > > > > rack introduced a dependency on ruby 2.2.2 or greater in > > https://github.com/rack/rack/commit/771d94e5dbe53058160a1f8a4cc56384c1d2a048 > > Cc-ing rack-devel + Aaron > > Yikes! ruby-core still supports Ruby 2.1 and possibly even 2.0.0 > > And there doesn't seem to be any documentation on why Ruby 2.2.x > is needed in the first place for rack.git > commit a2fe30a5e70371c89c1b29fdc2dc5f8027bc5fe6 > > http://bogomips.org/mirrors/rack.git/patch?id=a2fe30a5e70371c8 > > Aaron? The main reason I bumped it up to Ruby 2.2.x is because that will be the minimum version of Ruby I'll be stuck with throughout Rack 2.x's lifetime. IOW, I can't drop Ruby versions in anything but a major release so I'm being conservative and only going with the latest (at the time that was 2.2). I could be convinced to bring down the version number, but I'd like to know why first. :) > > In order to maintain support for ruby versions less than 2.2.2, limit > > the rack dependency to supported versions for the current ruby. > > --- > > unicorn.gemspec | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/unicorn.gemspec b/unicorn.gemspec > > index 1099361..ce7080a 100644 > > --- a/unicorn.gemspec > > +++ b/unicorn.gemspec > > @@ -35,7 +35,11 @@ > > # up/downgrade to any other version, the Rack dependency may be > > # commented out. Nevertheless, upgrading to Rails 2.3.4 or later is > > # *strongly* recommended for security reasons. > > - s.add_dependency(%q) > > + if RUBY_VERSION < '2.2.2' > > + s.add_dependency(%q, '~> 1.6.4') > > + else > > + s.add_dependency(%q) > > + end > > Interesting, I built a gem with RubyGems 2.5.1 and this conditional > was preserved in the gemspec. I tried this in the past (2009/2010?) > and any conditionals written like this got clobbered in the final > gemspec. I wonder if that's true even after you upload to rubygems.org. I'd guess it's not true as they don't want to support arbitrary ruby code for specs. > In other words, conditionals used to be evaluated at "gem build" time, > not "gem install" time. We should check when this improvement was > introduced into RubyGems should we go this route. > > Also, maybe '~> 1.6.4' is too strict, '~> 1.6' could be better in case > a rack 1.7 comes out in parallel to rack 2.0 Agree here. 1.7 may be possible, and I want to make the guarantee that its API is backwards compatible with 1.6. -- Aaron Patterson http://tenderlovemaking.com/ -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJWkC82AAoJEJUxcLy0/6/GDDIH/3tzg27dWUi8D7KtVF83Hbvy YVb8d7y6GWxqfhjydW7Ud5zLMJCxiITgGFafJeTpq1YVY/wpQ058Bg76gBqB8kVH bIR6rdtpUQyn7VMNdXd/gm03t5Ww8YyqeExIJk5qzWJtCvDa6wZnbUu/2NuaNG+B 11k/25gIoRu0np6VcrmwHx6ZIPJN6YBTSMhlJxKRSrztWPN9RkcTHUNUjbnpk1mr DGLJPTJu/bR3IiEiU3JOeMeXU83p4bqVmMkMTEnATfFryRXLRcunaaW5CaAUQm90 zD0zGNvCbgmcWvJQiffRNDFv7U1VmRxexePgk5dlPb/Tyn9oSK9Gx+ic2YJ1THg= =LtOr -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--