rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: rack-devel@googlegroups.com
Cc: "Marc-André Cournoyer" <macournoyer@gmail.com>,
	"Hongli Lai" <honglilai@gmail.com>
Subject: Re: Close body object after socket hijacking or not?
Date: Thu, 4 Jun 2015 02:11:57 +0000	[thread overview]
Message-ID: <20150604021157.GA20396@dcvr.yhbt.net> (raw)
In-Reply-To: <f121aeba-4633-4cf0-8f45-a5998f3fd6eb@googlegroups.com>

Hongli Lai <honglilai@gmail.com> wrote:
> On Friday, April 17, 2015 at 10:43:38 PM UTC+2, Eric Wong wrote:
> >
> > I would like clarication on this issue, too.  Ping? 
> >
> 
> No clarification has appeared. But as far as I'm concerned, closing the 
> body anyway is the best thing to do. Rack::Lock is currently broken if we 
> *don't* close the body upon hijacking, and there seems to be no 
> alternative. I'll modify Passenger to follow this behavior. Starting from 
> version 5.0.9, Passenger will also close the body upon hijacking, just like 
> Puma and Thin.

Where does thin do this?  I can see puma doing it, but it doesn't look
like thin supports hijack at all.

git clone git://github.com/macournoyer/thin && cd thin && git grep -i hijack
<no output from git grep>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2015-06-04  2:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 21:26 Hongli Lai
2015-04-17 20:43 ` Eric Wong
2015-05-29 14:09   ` Hongli Lai
2015-06-04  2:11     ` Eric Wong [this message]
2015-06-04  6:53       ` Hongli Lai
2015-06-04 12:38         ` Marc-André Cournoyer
2015-06-28 20:46           ` James Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604021157.GA20396@dcvr.yhbt.net \
    --to=rack-devel@googlegroups.com \
    --cc=honglilai@gmail.com \
    --cc=macournoyer@gmail.com \
    --subject='Re: Close body object after socket hijacking or not?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).