Re: Close body object after socket hijacking or not?

[Eric Wong <e@80x24.org>]

Hongli Lai <honglilai@gmail.com> wrote:
> On Friday, April 17, 2015 at 10:43:38 PM UTC+2, Eric Wong wrote:
> >
> > I would like clarication on this issue, too.  Ping? 
> >
> 
> No clarification has appeared. But as far as I'm concerned, closing the 
> body anyway is the best thing to do. Rack::Lock is currently broken if we 
> *don't* close the body upon hijacking, and there seems to be no 
> alternative. I'll modify Passenger to follow this behavior. Starting from 
> version 5.0.9, Passenger will also close the body upon hijacking, just like 
> Puma and Thin.

Where does thin do this?  I can see puma doing it, but it doesn't look
like thin supports hijack at all.

git clone git://github.com/macournoyer/thin && cd thin && git grep -i hijack
<no output from git grep>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.