From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.142.191.1 with SMTP id o1cs933110wff; Wed, 30 Dec 2009 17:22:56 -0800 (PST) Received: from mr.google.com ([10.114.162.37]) by 10.114.162.37 with SMTP id k37mr12179135wae.29.1262222575944 (num_hops = 1); Wed, 30 Dec 2009 17:22:55 -0800 (PST) Received: by 10.114.162.37 with SMTP id k37mr2656256wae.29.1262222574469; Wed, 30 Dec 2009 17:22:54 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.115.116.23 with SMTP id t23ls329076wam.1.p; Wed, 30 Dec 2009 17:22:53 -0800 (PST) Received: by 10.115.116.7 with SMTP id t7mr4456128wam.25.1262222572921; Wed, 30 Dec 2009 17:22:52 -0800 (PST) Received: by 10.115.116.7 with SMTP id t7mr4456127wam.25.1262222572898; Wed, 30 Dec 2009 17:22:52 -0800 (PST) Return-Path: Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by gmr-mx.google.com with ESMTP id 23si4462207pxi.4.2009.12.30.17.22.52; Wed, 30 Dec 2009 17:22:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of normalperson@yhbt.net designates 64.71.152.64 as permitted sender) client-ip=64.71.152.64; Received: from localhost (unknown [127.0.2.5]) by dcvr.yhbt.net (Postfix) with ESMTP id 3B3481F548; Thu, 31 Dec 2009 01:22:52 +0000 (UTC) Date: Wed, 30 Dec 2009 17:22:52 -0800 From: Eric Wong To: rack-devel@googlegroups.com Subject: Re: Call for 1.1.0 release Message-ID: <20091231012252.GB7600@dcvr.yhbt.net> References: <9363563c-cbd4-498f-b9ee-b3ee83fa15b8@r5g2000yqb.googlegroups.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of normalperson@yhbt.net designates 64.71.152.64 as permitted sender) smtp.mail=normalperson@yhbt.net X-Original-Sender: normalperson@yhbt.net Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/d1b335121da4dc68 X-Message-Url: http://groups.google.com/group/rack-devel/msg/d94c4d3c0e144701 Sender: rack-devel@googlegroups.com List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ryan Tomayko wrote: > Rack, Sinatra, and Rack::Cache test suites all pass under MRI > 1.8.6/1.8.7 and REE 1.8.7. I can't get test-spec to run under 1.9 for > some reason so I haven't been able to test there. I sent the patches ad the end of this message to Christian which should get test-spec mostly working under 1.9 (though I can't get test-spec to pass its own tests). Under all versions of Ruby I tested, the basic test suite fails spec_rack_logger.rb: <"Program started\nNothing to do!\n"> expected to be =~ . It looks like the Logger formatter gets clobbered somewhere, running that test standalone seems to work fine, though. Running Ruby 1.9.2dev trunk r26127, everything else passes except the following because of a Marshal format change: test_spec {Rack::Session::Cookie} 005 [creates a new cookie with integrity hash](Rack::Session::Cookie) [/home/ew/rack/test/spec_rack_session_cookie.rb:55]: <"rack.session=BAh7BkkiDGNvdW50ZXIGOgZFRmkG%0A--2548b2a97e67656c3457b9a5cb43b65a83715cbc; path=/"> expected to be =~ . test-spec patches below: --------------------------------- 8< --------------------------------- Wed Dec 30 23:22:17 UTC 2009 normalperson@yhbt.net * add "spec" pattern for automatic tests test-unit 2.0.5 (required for Ruby 1.9) doesn't automatically glob patterns beginning with "spec". Wed Dec 30 22:24:51 UTC 2009 normalperson@yhbt.net * Rakefile: String#each -> String#each_line for 1.9 String#each no longer exists in Ruby 1.9 diff -rN -u old-testspec/bin/specrb new-testspec/bin/specrb --- old-testspec/bin/specrb 2009-12-31 01:00:08.000000000 +0000 +++ new-testspec/bin/specrb 2009-12-31 01:00:08.000000000 +0000 @@ -104,4 +104,10 @@ runner = Test::Unit::AutoRunner.new true runner.process_args(argv) || abort("internal error calling Test::Unit, please report a bug") + +# needed for test-unit 2.0.5 under Ruby 1.9 +if automatic && RUBY_VERSION.to_f >= 1.9 + runner.pattern << %r{\Aspec[_\-].+\.rb\z}m +end + exit runner.run diff -rN -u old-testspec/Rakefile new-testspec/Rakefile --- old-testspec/Rakefile 2009-12-31 01:00:08.000000000 +0000 +++ new-testspec/Rakefile 2009-12-31 01:00:08.000000000 +0000 @@ -27,7 +27,7 @@ count = 0 tag = "0.0" - changes.each("\n\n") { |change| + changes.each_line("\n\n") { |change| head, title, desc = change.split("\n", 3) if title =~ /^ \*/ -- Eric Wong