Re: Call for 1.1.0 release

[Eric Wong <normalperson@yhbt.net>]

Ryan Tomayko <r@tomayko.com> wrote:
> Rack, Sinatra, and Rack::Cache test suites all pass under MRI
> 1.8.6/1.8.7 and REE 1.8.7. I can't get test-spec to run under 1.9 for
> some reason so I haven't been able to test there.

I sent the patches ad the end of this message to Christian which should
get test-spec mostly working under 1.9 (though I can't get test-spec to
pass its own tests).

Under all versions of Ruby I tested, the basic test suite fails
spec_rack_logger.rb:

  <"Program started\nNothing to do!\n"> expected to be =~
  </INFO\ \-\-\ :\ Program\ started/>.

  It looks like the Logger formatter gets clobbered somewhere,
  running that test standalone seems to work fine, though.

Running Ruby 1.9.2dev trunk r26127, everything else passes except the
following because of a Marshal format change:

  test_spec {Rack::Session::Cookie} 005 [creates a new cookie with integrity hash](Rack::Session::Cookie) [/home/ew/rack/test/spec_rack_session_cookie.rb:55]:
  <"rack.session=BAh7BkkiDGNvdW50ZXIGOgZFRmkG%0A--2548b2a97e67656c3457b9a5cb43b65a83715cbc; path=/"> expected to be =~
  </rack\.session=BAh7BkkiDGNvdW50ZXIGOg1lbmNvZGluZyINVVMtQVNDSUlpBg%3D%3D%0A\-\-d7a6637b94d2728194a96c18484e1f7ed9074a83/>.


test-spec patches below:
--------------------------------- 8< ---------------------------------

Wed Dec 30 23:22:17 UTC 2009  normalperson@yhbt.net
  * add "spec" pattern for automatic tests
  
  test-unit 2.0.5 (required for Ruby 1.9) doesn't automatically
  glob patterns beginning with "spec".
Wed Dec 30 22:24:51 UTC 2009  normalperson@yhbt.net
  * Rakefile: String#each -> String#each_line for 1.9
  
  String#each no longer exists in Ruby 1.9
diff -rN -u old-testspec/bin/specrb new-testspec/bin/specrb
--- old-testspec/bin/specrb	2009-12-31 01:00:08.000000000 +0000
+++ new-testspec/bin/specrb	2009-12-31 01:00:08.000000000 +0000
@@ -104,4 +104,10 @@
 runner = Test::Unit::AutoRunner.new true
 runner.process_args(argv) ||
   abort("internal error calling Test::Unit, please report a bug")
+
+# needed for test-unit 2.0.5 under Ruby 1.9
+if automatic && RUBY_VERSION.to_f >= 1.9
+  runner.pattern << %r{\Aspec[_\-].+\.rb\z}m
+end
+
 exit runner.run
diff -rN -u old-testspec/Rakefile new-testspec/Rakefile
--- old-testspec/Rakefile	2009-12-31 01:00:08.000000000 +0000
+++ new-testspec/Rakefile	2009-12-31 01:00:08.000000000 +0000
@@ -27,7 +27,7 @@
   count = 0
   tag = "0.0"
   
-  changes.each("\n\n") { |change|
+  changes.each_line("\n\n") { |change|
     head, title, desc = change.split("\n", 3)
     
     if title =~ /^  \*/

-- 
Eric Wong