From: Eric Wong <normalperson@yhbt.net>
To: rack-devel@googlegroups.com
Subject: Re: [ANN/RFC] LMGTWTY - Web Sockets for Rack+Rainbows!
Date: Sun, 13 Dec 2009 16:51:15 -0800 [thread overview]
Message-ID: <20091214005115.GA20471@dcvr.yhbt.net> (raw)
In-Reply-To: <d44890b20912131623j3a91f1exc5b2cd212afd1535@mail.gmail.com>
Lakshan Perera <perera.lakshan@gmail.com> wrote:
> Hi Eric,
>
> This is awesome! Thanks for coming up something like this, in a short period
> of time.
> I hope this would be part of Rack, which would enable all Ruby Frameworks to
> work effortlessly with WebSockets.
Yes, agreed, but the other thing is that Sunshowers can also be used
for clients (without needing extra code), so the gem doesn't depend
on Rack nor Rainbows! at the moment.
> BTW, I found a small fix is needed to get this work correctly with Google
> Chrome Beta. As described in Section 3.2
> <http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-55#section-3.2>in
> IETF's "The Web Socket protocol" resource name(uri) needs to be appended
> when constructing the WebSocket URLs. This needs to be adhered in the
> WebSocket-Location value of the handshake header.
>
> I have attached a patch which fulfills this requirement.
--- a/lib/sunshowers/web_socket.rb
+++ b/lib/sunshowers/web_socket.rb
@@ -58,6 +58,11 @@ module Sunshowers
protocol
end
+ # returns the requested resource name
+ def ws_resource_name
+ @env["REQUEST_URI"]
+ end
Thanks Lackshan!
But shouldn't it be (our good friend) PATH_INFO instead of REQUEST_URI?
REQUEST_URI is both:
a) not required by Rack
b) includes QUERY_STRING
--
Eric Wong
next prev parent reply other threads:[~2009-12-14 0:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 20:19 [ANN/RFC] LMGTWTY - Web Sockets for Rack+Rainbows! Eric Wong
2009-12-11 21:37 ` Eric Wong
2009-12-12 0:09 ` Daniel N
2009-12-13 9:09 ` Eric Wong
2009-12-13 20:53 ` Eric Wong
2009-12-14 0:23 ` Lakshan Perera
2009-12-14 0:51 ` Eric Wong [this message]
2009-12-14 0:57 ` Eric Wong
2009-12-14 10:41 ` James Tucker
2009-12-14 18:42 ` Eric Wong
2009-12-15 1:00 ` James Tucker
2009-12-15 4:37 ` Eric Wong
2009-12-15 11:15 ` James Tucker
2009-12-15 21:32 ` Eric Wong
2009-12-16 10:57 ` James Tucker
2009-12-16 22:14 ` Eric Wong
2009-12-17 3:23 ` James Tucker
2009-12-17 8:47 ` Eric Wong
2009-12-17 11:54 ` James Tucker
2009-12-16 12:38 ` James Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214005115.GA20471@dcvr.yhbt.net \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).