From: Eric Wong <normalperson@yhbt.net>
To: rack-devel@googlegroups.com
Subject: Re: Questions about the Prohibition of String Subclasses in responses
Date: Mon, 5 Oct 2009 19:52:40 -0700 [thread overview]
Message-ID: <20091006025239.GB23138@dcvr.yhbt.net> (raw)
In-Reply-To: <ef46c93e0910051738g19974a3ds6a9d8c0bb4f43589@mail.gmail.com>
Michael Koziarski <michael@koziarski.com> wrote:
> I guess fundamentally I'm still not seeing a reason for the current
> restriction to no-child-classes beyond 'might break C-extensions'.
> What kind of code is in those c extensions which might break? We could
> verify our subclasses with that same kind of code and see what
> happens. The whole purpose of inheritance is to ensure subtypes can
> be used interchangably, we've put some effort into making sure we're
> 'liskov-approved'[1] and I'd be surprised if anything breaks.
Actually, I think the vast majority of subclasses are safe.
Very contrived, but only(?) subclasses implemented in C that redefine
their internal representation to something incompatible with their
(expected) superclass would get broken (when accessed by other C
extensions).
Fortunately I don't know of any extensions that crazy as there's no
point in subclassing at that point. And if there are, maybe people
using them deserve to get their apps broken :>
> Having said that, I've been surprised before
Part of me wants to apply this change and stick it into a release just
to see what (if anything it) breaks. Fortunately for the rest of you
I'm not part of the Rack core team :)
--
Eric Wong
next prev parent reply other threads:[~2009-10-06 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 21:58 Questions about the Prohibition of String Subclasses in responses Michael Koziarski
2009-10-05 23:02 ` Eric Wong
2009-10-05 23:22 ` Eric Wong
2009-10-06 0:38 ` Michael Koziarski
2009-10-06 2:52 ` Eric Wong [this message]
2009-10-06 6:40 ` Michael Koziarski
2009-10-06 14:23 ` James Tucker
2009-10-06 8:05 ` James Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://groups.google.com/group/rack-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006025239.GB23138@dcvr.yhbt.net \
--to=rack-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).