From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.204.72.79 with SMTP id l15cs745901bkj; Wed, 12 Aug 2009 22:44:36 -0700 (PDT) Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.114.32.35 as permitted sender) client-ip=10.114.32.35; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.114.32.35 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.114.32.35]) by 10.114.32.35 with SMTP id f35mr182099waf.0.1250142275239 (num_hops = 1); Wed, 12 Aug 2009 22:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received:date :from:to:subject:message-id:references:mime-version:content-type :content-disposition:content-transfer-encoding:in-reply-to :user-agent:reply-to:sender:precedence:x-google-loop:mailing-list :list-id:list-post:list-help:list-unsubscribe:x-beenthere-env :x-beenthere; bh=mBeDTNctbynth8cWx08xWUv32XjdHDaCjcg1fs/BZkE=; b=raJCPSt62pifwbJVSKYBch/rtabWHAuHnlWGet7H9RteI8xAPjl28Mzy+cLXN4CY8j RgFMmnRUxsZOTXqiz6gdI1PEsCmy3r3Nm3HOBMZTyY0oXoFBoJ4POLdpMbVZY4ia0tyg wa2Xbjqn6Y5GPEvpgJi93cV8cX+L0j55fR79c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results:date :from:to:subject:message-id:references:mime-version:content-type :content-disposition:content-transfer-encoding:in-reply-to :user-agent:reply-to:sender:precedence:x-google-loop:mailing-list :list-id:list-post:list-help:list-unsubscribe:x-beenthere-env :x-beenthere; b=2AHc7rdAdH7yOaFjnkEHS/WdkeZij4b6eMLD+xAfITTxRCMBBO38JuCiassAhZOYCQ kj2qzvodMOlzsz/+jqs4lHK6pTUOFP5mkN0+ARg0P/tcbqtjn4P38m5So+1jnA2dc5v5 6gob3geZWYAJVdtC0KviYA4kvQEbF44M6fVPE= Received: by 10.114.32.35 with SMTP id f35mr32911waf.0.1250142274901; Wed, 12 Aug 2009 22:44:34 -0700 (PDT) Received: by 10.107.167.28 with SMTP id u28gr1571pro.0; Wed, 12 Aug 2009 22:44:33 -0700 (PDT) X-Sender: normalperson@yhbt.net X-Apparently-To: rack-devel@googlegroups.com Received: by 10.142.75.6 with SMTP id x6mr67270wfa.8.1250142272424; Wed, 12 Aug 2009 22:44:32 -0700 (PDT) Return-Path: Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by gmr-mx.google.com with ESMTP id 24si736737pzk.5.2009.08.12.22.44.32; Wed, 12 Aug 2009 22:44:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of normalperson@yhbt.net designates 64.71.152.64 as permitted sender) client-ip=64.71.152.64; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of normalperson@yhbt.net designates 64.71.152.64 as permitted sender) smtp.mail=normalperson@yhbt.net Received: from localhost (user-118bg0q.cable.mindspring.com [66.133.192.26]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPSA id C616E1F7E2; Thu, 13 Aug 2009 05:44:31 +0000 (UTC) Date: Wed, 12 Aug 2009 22:44:31 -0700 From: Eric Wong To: rack-devel@googlegroups.com Subject: Re: Downsizing CommonLogger Message-ID: <20090813054431.GA26691@dcvr.yhbt.net> References: <69a2885c0904290803j292d2c45j5a46d0e759b6272a@mail.gmail.com> <20090430002127.7bd983f1@sigma.localdomain> <69a2885c0905131852h2ee62731o72337bec5490742e@mail.gmail.com> <2a8d4a710905132214s1cb24b4brea19d6f684be20c7@mail.gmail.com> <1c5622660905140728i3c162e1erf2e3058f79c80357@mail.gmail.com> <20090812011427.GA4737@dcvr.yhbt.net> <20090812023813.GA5916@dcvr.yhbt.net> <69a2885c0908121456w41348d4cjff273bbbed958fe3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <69a2885c0908121456w41348d4cjff273bbbed958fe3@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com Jeremy Kemper wrote: > On Tue, Aug 11, 2009 at 9:38 PM, Eric Wong wrote: > > Eric Wong wrote: > >> Christian Neukirchen wrote: > >> > Does it log the right size for chunked outputs?  In logfiles, I want those... > >> This also miscalculates request time if the body is being generated > >> dynamically during #each. > Hey Eric, > > Nice patch, but these changes were intentional. CommonLogger's concern > is logging the request, not calculating content length edge cases or > acting as a benchmarker. I'd advocate removing the timing entirely; > it's not part of the Common Log Format. Hi Jeremy, Good point about the timing not being part of CLF. I suppose everybody could create their own BikeshedLogger since everybody I know has their own ideas on what's useful/not useful in a logger :) -- Eric Wong