rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* RQFR: multipart bug
@ 2009-11-06 18:01 Christian Neukirchen
  2009-11-11 20:53 ` Bosko Milekic
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Neukirchen @ 2009-11-06 18:01 UTC (permalink / raw)
  To: Rack Development


> Introduce failing test case for multipart parser when it slices
> exactly on a boundary and patch multipart parser so it passes it -
> the failing test case comes with a sample payload specific to the
> fact that the default bufsize used by the multipart parser is
> exactly 16384.  should this default be changed, the test will no
> longer apply.

http://github.com/bloom/rack/commit/8f4bfced74e7a07d0f0f47705b763c7efc2f2aa7

-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RQFR: multipart bug
  2009-11-06 18:01 RQFR: multipart bug Christian Neukirchen
@ 2009-11-11 20:53 ` Bosko Milekic
  2009-12-09  5:55   ` Bosko Milekic
  0 siblings, 1 reply; 3+ messages in thread
From: Bosko Milekic @ 2009-11-11 20:53 UTC (permalink / raw)
  To: Rack Development



On Nov 6, 1:01 pm, Christian Neukirchen <chneukirc...@gmail.com>
wrote:
> > Introduce failing test case for multipart parser when it slices
> > exactly on a boundary and patch multipart parser so it passes it -
> > the failing test case comes with a sample payload specific to the
> > fact that the default bufsize used by the multipart parser is
> > exactly 16384.  should this default be changed, the test will no
> > longer apply.
>
> http://github.com/bloom/rack/commit/8f4bfced74e7a07d0f0f47705b763c7ef...

Obviously I'll +1 here, but I'm clearly biased. :-)

In all honesty, though, I think the "correct" thing to do is rewrite
the multi-parser method, which is really non obvious and not exactly
what one would call idiomatic ruby, but since this is much easier said
than done, I'm all for patching the edge case.  Took a while to
isolate this, especially since only Safari was sending payloads that
happened to, in very specific and isolated cases, fall exactly on the
end of the boundary at the 16384 byte offset.

Best,
Bosko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RQFR: multipart bug
  2009-11-11 20:53 ` Bosko Milekic
@ 2009-12-09  5:55   ` Bosko Milekic
  0 siblings, 0 replies; 3+ messages in thread
From: Bosko Milekic @ 2009-12-09  5:55 UTC (permalink / raw)
  To: Rack Development


On Nov 11, 3:53 pm, Bosko Milekic <bosko.mile...@gmail.com> wrote:
> On Nov 6, 1:01 pm, Christian Neukirchen <chneukirc...@gmail.com>
> wrote:
>
> > > Introduce failing test case for multipart parser when it slices
> > > exactly on a boundary and patch multipart parser so it passes it -
> > > the failing test case comes with a sample payload specific to the
> > > fact that the default bufsize used by the multipart parser is
> > > exactly 16384.  should this default be changed, the test will no
> > > longer apply.
>
> >http://github.com/bloom/rack/commit/8f4bfced74e7a07d0f0f47705b763c7ef...
>
> Obviously I'll +1 here, but I'm clearly biased. :-)
>
> In all honesty, though, I think the "correct" thing to do is rewrite
> the multi-parser method, which is really non obvious and not exactly
> what one would call idiomatic ruby, but since this is much easier said
> than done, I'm all for patching the edge case.  Took a while to
> isolate this, especially since only Safari was sending payloads that
> happened to, in very specific and isolated cases, fall exactly on the
> end of the boundary at the 16384 byte offset.
>
> Best,
> Bosko

FWIW:
Feel free to pull bloom/rack. gdi contributed a cleaner fix and tests
and we've been running this in production for a month now.

Best,
Bosko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-12-09  5:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-06 18:01 RQFR: multipart bug Christian Neukirchen
2009-11-11 20:53 ` Bosko Milekic
2009-12-09  5:55   ` Bosko Milekic

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).