From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.142.191.1 with SMTP id o1cs133417wff; Fri, 20 Nov 2009 18:10:32 -0800 (PST) Received: from mr.google.com ([10.223.98.206]) by 10.223.98.206 with SMTP id r14mr222551fan.19.1258769430294 (num_hops = 1); Fri, 20 Nov 2009 18:10:30 -0800 (PST) Received: by 10.223.98.206 with SMTP id r14mr79601fan.19.1258769428917; Fri, 20 Nov 2009 18:10:28 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.223.143.82 with SMTP id t18ls1931fau.0.p; Fri, 20 Nov 2009 18:10:26 -0800 (PST) Received: by 10.223.164.103 with SMTP id d39mr80191fay.14.1258769426612; Fri, 20 Nov 2009 18:10:26 -0800 (PST) Received: by 10.223.164.103 with SMTP id d39mr80190fay.14.1258769426588; Fri, 20 Nov 2009 18:10:26 -0800 (PST) Return-Path: Received: from mail-fx0-f218.google.com (mail-fx0-f218.google.com [209.85.220.218]) by gmr-mx.google.com with ESMTP id 11si29926fxm.14.2009.11.20.18.10.25; Fri, 20 Nov 2009 18:10:25 -0800 (PST) Received-SPF: pass (google.com: domain of joshpeek@gmail.com designates 209.85.220.218 as permitted sender) client-ip=209.85.220.218; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of joshpeek@gmail.com designates 209.85.220.218 as permitted sender) smtp.mail=joshpeek@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by fxm10 with SMTP id 10so1558824fxm.14 for ; Fri, 20 Nov 2009 18:10:25 -0800 (PST) MIME-Version: 1.0 Sender: joshpeek@gmail.com Received: by 10.223.143.21 with SMTP id s21mr329458fau.54.1258769425478; Fri, 20 Nov 2009 18:10:25 -0800 (PST) In-Reply-To: <245fb4700911201652s63cafa2fg160820c7dce479ec@mail.gmail.com> References: <245fb4700911201642h56b9e639u20748e5a2117fbe8@mail.gmail.com> <245fb4700911201652s63cafa2fg160820c7dce479ec@mail.gmail.com> From: Joshua Peek Date: Fri, 20 Nov 2009 18:10:05 -0800 Message-ID: <1c5622660911201810v4cd86215ve20fb6a09864afe5@mail.gmail.com> Subject: Re: Rack::Server patch To: rack-devel@googlegroups.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/3eefabb1a33778df X-Message-Url: http://groups.google.com/group/rack-devel/msg/32e69dc478f1de31 List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable +1 Looks good. My only suggestion would be to keep the old pid/daemonize behavior. So don't set a default pid file and only set one if its provided. On Fri, Nov 20, 2009 at 4:52 PM, Yehuda Katz wrote: > Patches attached. > [1] tests_patch.diff -- Adds tests for the functionality of rackup > [2]=C2=A0rack_server_patch.diff -- Moves Rack::Server into a separate obj= ect > Yehuda Katz > Developer | Engine Yard > (ph) 718.877.1325 > > > 2009/11/20 Yehuda Katz >> >> Hey guys, >> Carl and I spent a couple of day refactoring the code in bin/rackup into >> Rack::Server. The main motivation for this was to enable Rails to ditch = our >> code in script/server and simply inherit from the requisite Rack code. I >> think the code improvement speaks for itself. In the process of this wor= k, >> we also moved a few things out of Rackup into more usable locations, lik= e >> Rack::Handler.default (to get the handler that Rack will use if none is >> specified) and Rack::Builder.parse_file (which we currently duplicate in >> ActionDispatch). >> You can check out the changes at github.com/carllerche/rack, and I have >> also attached a patch. In addition to converting the rackup binary to a >> class, we also wrote tests for each function of rackup, to be sure we >> wouldn't break anything in the refactor. As a result, this patch now has >> tests for rackup! >> Yehuda Katz >> Developer | Engine Yard >> (ph) 718.877.1325 > > --=20 Joshua Peek