rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / code / Atom feed
* newby issue with rack-ssl gem
@ 2016-12-18  0:32 Rich Morin
  2016-12-18  1:08 ` James Tucker
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Rich Morin @ 2016-12-18  0:32 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 741 bytes --]

 

I'm using Rack via Sinatra and Thin, serving HTTPS on port 44567.  That 
works, but I'm not able to set up automated transfers from HTTP to HTTPS.  I'm 
trying to use the rack-ssl gem to force this, but not seeing any effect.


I assume that I'm simply calling it wrong.  Might anyone have suggestions?


FWIW, here's a Gist that documents and demonstrates the issue:


 https://gist.github.com/RichMorin/62d5594237e487242f027ca51cafa290


-r

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 2514 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: newby issue with rack-ssl gem
  2016-12-18  0:32 newby issue with rack-ssl gem Rich Morin
@ 2016-12-18  1:08 ` James Tucker
  2016-12-18  1:42   ` Rich Morin
  2016-12-18  1:51 ` Rich Morin
  2016-12-18 18:04 ` Rich Morin
  2 siblings, 1 reply; 7+ messages in thread
From: James Tucker @ 2016-12-18  1:08 UTC (permalink / raw)
  To: Rack Development

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

This is a web server issue, not a rack issue. Most webservers will not let
you serve plaintext and TLS over the same port. When I say most, I mean I
don't know of any ruby webservers that support this, as all of them rely on
openssl listen sockets for TLS.

On Dec 17, 2016 5:03 PM, "Rich Morin" <rdm@cfcl.com> wrote:

> I'm using Rack via Sinatra and Thin, serving HTTPS on port 44567.  That
> works, but I'm not able to set up automated transfers from HTTP to HTTPS.
>  I'm trying to use the rack-ssl gem to force this, but not seeing any
> effect.
>
>
> I assume that I'm simply calling it wrong.  Might anyone have suggestions?
>
>
> FWIW, here's a Gist that documents and demonstrates the issue:
>
>
>  https://gist.github.com/RichMorin/62d5594237e487242f027ca51cafa290
>
>
> -r
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rack-devel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 3002 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: newby issue with rack-ssl gem
  2016-12-18  1:08 ` James Tucker
@ 2016-12-18  1:42   ` Rich Morin
  2016-12-18  1:49     ` James Tucker
  0 siblings, 1 reply; 7+ messages in thread
From: Rich Morin @ 2016-12-18  1:42 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 997 bytes --]

On Saturday, December 17, 2016 at 5:08:12 PM UTC-8, raggi wrote:
>
> This is a web server issue, not a rack issue. Most webservers will not let 
> you serve plaintext and TLS over the same port. When I say most, I mean I 
> don't know of any ruby webservers that support this, as all of them rely on 
> openssl listen sockets for TLS.
>

Hmmm.  A lot of web servers I've encountered force a switch from HTTP to 
HTTPS, but then, they're also switching from port 80 to port 443.  I 
suppose that I could redirect requests from (say) http://<IP>:34567/... to 
https://<IP>:44567/..., but I'm not sure how useful that would be.  Also, 
not exactly sure how to do this.

Any other suggestions, anyone?

-r

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 1427 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: newby issue with rack-ssl gem
  2016-12-18  1:42   ` Rich Morin
@ 2016-12-18  1:49     ` James Tucker
  0 siblings, 0 replies; 7+ messages in thread
From: James Tucker @ 2016-12-18  1:49 UTC (permalink / raw)
  To: Rack Development

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

On Dec 17, 2016 5:42 PM, "Rich Morin" <rdm@cfcl.com> wrote:

On Saturday, December 17, 2016 at 5:08:12 PM UTC-8, raggi wrote:
>
> This is a web server issue, not a rack issue. Most webservers will not let
> you serve plaintext and TLS over the same port. When I say most, I mean I
> don't know of any ruby webservers that support this, as all of them rely on
> openssl listen sockets for TLS.
>

Hmmm.  A lot of web servers I've encountered force a switch from HTTP to
HTTPS, but then, they're also switching from port 80 to port 443.


Thats precisely the point.

 I suppose that I could redirect requests from (say) http://<IP>:34567/...
to https://<IP>:44567/..., but I'm not sure how useful that would be.
Also, not exactly sure how to do this.

Any other suggestions, anyone?


Your other option is to fingerprint the first few bytes, which are more
than sufficient to determine http/http2/TLS clienthello/unknown. Like I
said, I don't know of any ruby implementations of this, so you'd likely
have to write one. It's not particularly tricky.



-r

-- 

---
You received this message because you are subscribed to the Google Groups
"Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 3277 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: newby issue with rack-ssl gem
  2016-12-18  0:32 newby issue with rack-ssl gem Rich Morin
  2016-12-18  1:08 ` James Tucker
@ 2016-12-18  1:51 ` Rich Morin
  2016-12-18  7:01   ` James Tucker
  2016-12-18 18:04 ` Rich Morin
  2 siblings, 1 reply; 7+ messages in thread
From: Rich Morin @ 2016-12-18  1:51 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 661 bytes --]

On a related note, the Rack::SSL page (https://github.com/josh/rack-ssl) 
says that it "Redirects all 'http' requests to 'https'".  However, it says 
nothing about port numbers and offers no options that I can see in this 
area.  I'd like to understand the exact behavior I *should* expect from it 
and whether there are any ways to play with port numbers, etc.

-r

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 1923 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: newby issue with rack-ssl gem
  2016-12-18  1:51 ` Rich Morin
@ 2016-12-18  7:01   ` James Tucker
  0 siblings, 0 replies; 7+ messages in thread
From: James Tucker @ 2016-12-18  7:01 UTC (permalink / raw)
  To: Rack Development

[-- Attachment #1: Type: text/plain, Size: 2822 bytes --]

On Dec 17, 2016 5:51 PM, "Rich Morin" <rdm@cfcl.com> wrote:

> On a related note, the Rack::SSL page (https://github.com/josh/rack-ssl)
> says that it "Redirects all 'http' requests to 'https'".  However, it
> says nothing about port numbers and offers no options that I can see in
> this area.  I'd like to understand the exact behavior I *should* expect
> from it and whether there are any ways to play with port numbers, etc.
>

rack-ssl isn't an official rack project. I don't know if Josh still hangs
around here.

rack-ssl works by inspecting the rack environment, as specified in
http://www.rubydoc.info/github/rack/rack/file/SPEC#The_Environment

Specifically it looks for (in order):

env['HTTPS'] == 'on'   # this is not part of the rack spec, iirc, it was
something mongrel and/or webrick do
env['HTTP_X_FORWARDED_PROTO] == 'https'  # this is the HTTP header
X-Forwarded-Proto, which is often configured to be produced by upstream
proxies. Further important notes anon.
env['rack.url_scheme'] == 'https' # this is the rack standard spec for a
webserver to inform an application that the request was served with https.

Port numbers would not be useful for identifying whether or not a
connection is https.

You should read the code for more details of rack-ssl's operation. It's
only 89 lines long.

Important notes on X-Forwaded-Proto:

rack-ssl is not safe for use without an upstream proxy that always
overwrites or sets X-Forwarded-Proto. Failure to prevent users from sending
you this value could otherwise lead to certain rare cases of downgrade
attacks on your service.

X-Forwaded-Proto while still extremely common is now a stale. RFC7239 was
standardized in 2014 and defines a Forwarded-For header, the contents of
which can specify this behavior. It is less used partly because it's new,
and partly because it's harder to manage given that it requires more
parsing. I'm also seeing a lot of cases in the wild now that the above RFC
is getting talked about here and there, of people defining Forwarded-Proto
instead, which is further incorrect.

*In case it isn't clear, unless you make further adjustments to your
server, using rack-ssl with the server from your gist is not safe.*

HTH


> -r
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Rack Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rack-devel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 5221 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: newby issue with rack-ssl gem
  2016-12-18  0:32 newby issue with rack-ssl gem Rich Morin
  2016-12-18  1:08 ` James Tucker
  2016-12-18  1:51 ` Rich Morin
@ 2016-12-18 18:04 ` Rich Morin
  2 siblings, 0 replies; 7+ messages in thread
From: Rich Morin @ 2016-12-18 18:04 UTC (permalink / raw)
  To: Rack Development


[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

Thanks for the detailed response!  At the moment, I've taken rack-ssl out 
of my code and simply tell folks to use the https url.

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 625 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-12-18 18:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-18  0:32 newby issue with rack-ssl gem Rich Morin
2016-12-18  1:08 ` James Tucker
2016-12-18  1:42   ` Rich Morin
2016-12-18  1:49     ` James Tucker
2016-12-18  1:51 ` Rich Morin
2016-12-18  7:01   ` James Tucker
2016-12-18 18:04 ` Rich Morin

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/rack.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).