From e67159e720994c7442636a7d5250ea8a49a85b28 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 11 Jan 2020 22:35:01 +0000 Subject: xt/git_async_cmp: do not slurp large OID list into memory I somehow thought "foreach (<$cat>)" could work like "while (<$cat>)" when it came to iterating over file handles... --- xt/git_async_cmp.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xt') diff --git a/xt/git_async_cmp.t b/xt/git_async_cmp.t index f8ffe3d9..18fce3db 100644 --- a/xt/git_async_cmp.t +++ b/xt/git_async_cmp.t @@ -27,7 +27,7 @@ my $async = timeit($nr, sub { my $cat = $git->popen(@cat); $git->cat_async_begin; - foreach (<$cat>) { + while (<$cat>) { my ($oid, undef, undef) = split(/ /); $git->cat_async($oid, $cb); } @@ -39,7 +39,7 @@ my $async = timeit($nr, sub { my $sync = timeit($nr, sub { my $dig = Digest::SHA->new(1); my $cat = $git->popen(@cat); - foreach (<$cat>) { + while (<$cat>) { my ($oid, undef, undef) = split(/ /); my $bref = $git->cat_file($oid); $dig->add($$bref); -- cgit v1.2.3-24-ge0c7