From 934fea5e3b3c4c1ef0cef29477941ebfc44ff7e0 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 9 Sep 2020 06:26:10 +0000 Subject: use "\&" where possible when referring to subroutines "*foo" is ambiguous in that it may refer to a bareword file handle; so we'll use it where we can without triggering warnings. PublicInbox::TestCommon::run_script_exit required dropping the prototype, however. We'll also future-proof by dropping "use warnings" in Cgit.pm and use the less-ambiguous "//=" in Inbox.pm while we're in the area. --- xt/msgtime_cmp.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xt/msgtime_cmp.t') diff --git a/xt/msgtime_cmp.t b/xt/msgtime_cmp.t index 0ce3c042..aa96be4d 100644 --- a/xt/msgtime_cmp.t +++ b/xt/msgtime_cmp.t @@ -62,7 +62,7 @@ my $fh = $git->popen(@cat); while (<$fh>) { my ($oid, $type) = split / /; next if $type ne 'blob'; - $git->cat_async($oid, *compare); + $git->cat_async($oid, \&compare); } $git->cat_async_wait; ok(1); -- cgit v1.2.3-24-ge0c7