From e48187f2ca08612e1eb1f987caa9cd5be48be27a Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 1 Jun 2019 00:20:51 +0000 Subject: git: unconditional expiry A constant stream of traffic to either httpd/nntpd would mean git-cat-file processes never expire. Things can go bad after a full repack, as a full repack will unlink old pack indices and git-cat-file does not currently detect unlinked files. We could do something complicated by recursively stat-ing objects/pack of every git directory and alternate; but that's probably not worth the trouble compared to occasionally restarting the cat-file process. So simplify the code and let httpd/nntpd expire them periodically, since spawning a "git-cat-file --batch" process isn't too expensive. We already spawn for every request which hits git-http-backend, cgit, and git-apply. In the future, we may optionally support the Git::Raw module to avoid IPC; but we must remain careful to not leave lingering FDs open to unlinked files after repack. --- t/git.t | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 't') diff --git a/t/git.t b/t/git.t index 7edf82b4..913f6e5e 100644 --- a/t/git.t +++ b/t/git.t @@ -143,8 +143,7 @@ if ('alternates reloaded') { my $config = eval { local $/; <$fh> }; is($$found, $config, 'alternates reloaded'); - ok($gcf->cleanup(time - 30), 'cleanup did not expire'); - ok(!$gcf->cleanup(time + 30), 'cleanup can expire'); + ok(!$gcf->cleanup, 'cleanup can expire'); ok(!$gcf->cleanup, 'cleanup idempotent'); my $t = $gcf->modified; -- cgit v1.2.3-24-ge0c7