From d73d783ab2cf14ba28ca63723223d8c85a68cdd5 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 2 Sep 2020 11:04:12 +0000 Subject: disambiguate OverIdx and Over by field name We'll use {oidx} as the common field name for the read-write OverIdx, here, to disambiguate it from the read-only {over} field. This hopefully makes it clearer which code paths are read-only and which are read-write. --- t/search-thr-index.t | 8 ++++---- t/search.t | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 't') diff --git a/t/search-thr-index.t b/t/search-thr-index.t index b5a5ff1f..bd663519 100644 --- a/t/search-thr-index.t +++ b/t/search-thr-index.t @@ -60,9 +60,9 @@ foreach (reverse split(/\n\n/, $data)) { my $prev; my %tids; -my $dbh = $rw->{over}->dbh; +my $dbh = $rw->{oidx}->dbh; foreach my $mid (@mids) { - my $msgs = $rw->{over}->get_thread($mid); + my $msgs = $rw->{oidx}->get_thread($mid); is(3, scalar(@$msgs), "got all messages from $mid"); foreach my $m (@$msgs) { my $tid = $dbh->selectrow_array(<<'', undef, $m->{num}); @@ -84,9 +84,9 @@ Message-Id: <1-bw@g> From: bw@g To: git@vger.kernel.org - my $dbh = $rw->{over}->dbh; + my $dbh = $rw->{oidx}->dbh; my ($id, $prev); - my $reidx = $rw->{over}->next_by_mid('1-bw@g', \$id, \$prev); + my $reidx = $rw->{oidx}->next_by_mid('1-bw@g', \$id, \$prev); ok(defined $reidx); my $num = $reidx->{num}; my $tid0 = $dbh->selectrow_array(<<'', undef, $num); diff --git a/t/search.t b/t/search.t index e2290ecd..f026e509 100644 --- a/t/search.t +++ b/t/search.t @@ -161,7 +161,7 @@ are real EOF my $ghost_id = $rw->add_message($was_ghost); is($ghost_id, int($ghost_id), "ghost_id is an integer: $ghost_id"); - my $msgs = $rw->{over}->get_thread('ghost-message@s'); + my $msgs = $rw->{oidx}->get_thread('ghost-message@s'); is(scalar(@$msgs), 2, 'got both messages in ghost thread'); foreach (qw(sid tid)) { is($msgs->[0]->{$_}, $msgs->[1]->{$_}, "{$_} match"); -- cgit v1.2.3-24-ge0c7