From d0755b0e3693b8497e7232cb31a53686a3181eb8 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 5 Apr 2014 01:11:08 +0000 Subject: view: implement quote folding and flesh out tests Unfortunately, quoting is often excessive, so hide multi-line quotes by default and provide anchored links to full messages instead. --- t/view.t | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 55 insertions(+), 2 deletions(-) (limited to 't') diff --git a/t/view.t b/t/view.t index df79bd49..fbdbd884 100644 --- a/t/view.t +++ b/t/view.t @@ -8,6 +8,17 @@ use PublicInbox::View; # plain text { + my $body = < keep this inline + +OK + +> Long and wordy reply goes here and it is split across multiple lines. +> We generate links to a separate full page where quoted-text is inline. + +hello world +EOF my $s = Email::Simple->create( header => [ From => 'a@example.com', @@ -16,7 +27,7 @@ use PublicInbox::View; 'Message-ID' => '', Subject => 'this is a subject', ], - body => "hello world\n", + body => $body, ); $s = Email::MIME->new($s->as_string); my $html = PublicInbox::View->as_html($s); @@ -24,6 +35,18 @@ use PublicInbox::View; # ghetto like($html, qr/]+>> Long and wordy/, + "long quoted text is anchored"); + + # short page + my $pfx = "http://example.com/test/full"; + my $short = PublicInbox::View->as_html($s, $pfx); + like($short, qr/\n> keep this inline/, + "short quoted text is inline"); + like($short, qr/]+>Long and wordy/, + "long quoted text is made into a link"); + ok(length($short) < length($html), "short page is shorter"); } # multipart crap @@ -49,7 +72,37 @@ use PublicInbox::View; ); my $html = PublicInbox::View->as_html($mime); - print $html; + like($html, qr/hi\n-+ part #2 -+\nbye\n/, "multipart split"); +} + +# multipart email with attached patch +{ + my $parts = [ + Email::MIME->create( + attributes => { content_type => 'text/plain', }, + body => 'hi, see attached patch', + ), + Email::MIME->create( + attributes => { + content_type => 'text/plain', + filename => "foo.patch", + }, + body => "--- a/file\n+++ b/file\n" . + "@@ -49, 7 +49,34 @@\n", + ), + ]; + my $mime = Email::MIME->create( + header_str => [ + From => 'a@example.com', + Subject => '[PATCH] asdf', + 'Message-ID' => '', + ], + parts => $parts, + ); + + my $html = PublicInbox::View->as_html($mime); + like($html, qr!see attached patch\n-+ foo\.patch -+\n--- a/file\n!, + "parts split with filename"); } done_testing(); -- cgit v1.2.3-24-ge0c7