From 9f5a583694396f84056b9d92255bba0197b52bc8 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 10 Jan 2020 09:14:19 +0000 Subject: spawn (and thus popen_rd) die on failure Most spawn and popen_rd callers die on failure to spawn, anyways, and some are missing checks entirely. This saves us a bunch of verbose error-checking code in callers. This also makes popen_rd more consistent, since it already dies on pipe creation failures. --- t/check-www-inbox.perl | 1 - 1 file changed, 1 deletion(-) (limited to 't') diff --git a/t/check-www-inbox.perl b/t/check-www-inbox.perl index db292c50..40209957 100644 --- a/t/check-www-inbox.perl +++ b/t/check-www-inbox.perl @@ -48,7 +48,6 @@ my $atom_check = eval { 2 => fileno($err_fh), }; my $pid = spawn($cmd, undef, $rdr); - defined $pid or die "spawn failure: $!"; while (waitpid($pid, 0) != $pid) { next if $!{EINTR}; warn "waitpid(xmlstarlet, $pid) $!"; -- cgit v1.2.3-24-ge0c7