From 64aea34d06f71828b0bdd6ae177b9bcf22d752b4 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 24 May 2016 03:41:53 +0000 Subject: git-http-backend: use qspawn to limit running processes Having an excessive amount of git-pack-objects processes is dangerous to the health of the server. Queue up process spawning for long-running responses and serve them sequentially, instead. --- t/qspawn.t | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 t/qspawn.t (limited to 't') diff --git a/t/qspawn.t b/t/qspawn.t new file mode 100644 index 00000000..05072e24 --- /dev/null +++ b/t/qspawn.t @@ -0,0 +1,60 @@ +# Copyright (C) 2016 all contributors +# License: AGPL-3.0+ +use Test::More; +use_ok 'PublicInbox::Qspawn'; +{ + my $x = PublicInbox::Qspawn->new([qw(true)]); + my $run = 0; + $x->start(sub { + my ($rpipe) = @_; + is(0, sysread($rpipe, my $buf, 1), 'read zero bytes'); + ok(!$x->finish, 'no error on finish'); + $run = 1; + }); + is($run, 1, 'callback ran alright'); +} + +{ + my $x = PublicInbox::Qspawn->new([qw(false)]); + my $run = 0; + $x->start(sub { + my ($rpipe) = @_; + is(0, sysread($rpipe, my $buf, 1), 'read zero bytes from false'); + my $err = $x->finish; + is($err, 256, 'error on finish'); + $run = 1; + }); + is($run, 1, 'callback ran alright'); +} + +foreach my $cmd ([qw(sleep 1)], [qw(sh -c), 'sleep 1; false']) { + my $s = PublicInbox::Qspawn->new($cmd); + my @run; + $s->start(sub { + my ($rpipe) = @_; + push @run, 'sleep'; + is(0, sysread($rpipe, my $buf, 1), 'read zero bytes'); + }); + my $n = 0; + my @t = map { + my $i = $n++; + my $x = PublicInbox::Qspawn->new([qw(true)]); + $x->start(sub { + my ($rpipe) = @_; + push @run, $i; + }); + [$x, $i] + } (0..2); + + if ($cmd->[-1] =~ /false\z/) { + ok($s->finish, 'got error on false after sleep'); + } else { + ok(!$s->finish, 'no error on sleep'); + } + ok(!$_->[0]->finish, "true $_->[1] succeeded") foreach @t; + is_deeply([qw(sleep 0 1 2)], \@run, 'ran in order'); +} + +done_testing(); + +1; -- cgit v1.2.3-24-ge0c7