From 55b707d788ce13696e4411389583e720ea6dab01 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 5 Jan 2020 23:23:35 +0000 Subject: treewide: "require" + "use" cleanup and docs There's a bunch of leftover "require" and "use" statements we no longer need and can get rid of, along with some excessive imports via "use". IO::Handle usage isn't always obvious, so add comments describing why a package loads it. Along the same lines, document the tmpdir support as the reason we depend on File::Temp 0.19, even though every Perl 5.10.1+ user has it. While we're at it, favor "use" over "require", since it it gives us extra compile-time checking. --- t/cgi.t | 2 -- t/feed.t | 2 -- 2 files changed, 4 deletions(-) (limited to 't') diff --git a/t/cgi.t b/t/cgi.t index 90543a7a..9f67d5c0 100644 --- a/t/cgi.t +++ b/t/cgi.t @@ -32,8 +32,6 @@ EOF close $fh or die "close: $!\n"; } -use_ok 'PublicInbox::Git'; -use_ok 'PublicInbox::Import'; use_ok 'PublicInbox::Inbox'; use_ok 'PublicInbox::InboxWritable'; use_ok 'PublicInbox::Config'; diff --git a/t/feed.t b/t/feed.t index b2a94487..ec8a5a42 100644 --- a/t/feed.t +++ b/t/feed.t @@ -5,9 +5,7 @@ use warnings; use Test::More; use Email::MIME; use PublicInbox::Feed; -use PublicInbox::Git; use PublicInbox::Import; -use PublicInbox::Config; use PublicInbox::Inbox; my $have_xml_feed = eval { require XML::Feed; 1 }; use PublicInbox::TestCommon; -- cgit v1.2.3-24-ge0c7