From 846161e3d1207d59f62b3a6718221d6f5ba2b94f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 28 May 2020 18:37:08 +0000 Subject: treat $INBOX_DIR/description and gitweb.owner as UTF-8 gitweb does the same with $GIT_DIR/description and gitweb.owner. Allowing UTF-8 description should not cause problems when used in responses for to the NNTP "LIST NEWSGROUPS" request, either, since RFC 3977 section 7.6.6 recommends the description be UTF-8 (but does not require it). Link: https://public-inbox.org/meta/20200528151216.l7vmnmrs4ojw372g@sourcephile.fr/ --- t/www_listing.t | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 't/www_listing.t') diff --git a/t/www_listing.t b/t/www_listing.t index 31d76356..0aededd4 100644 --- a/t/www_listing.t +++ b/t/www_listing.t @@ -46,7 +46,7 @@ sub tiny_test { unlike($tmp, qr/"modified":\s*"/, 'modified is an integer'); my $manifest = $json->decode($tmp); ok(my $clone = $manifest->{'/alt'}, '/alt in manifest'); - is($clone->{owner}, 'lorelei', 'owner set'); + is($clone->{owner}, "lorelei \x{100}", 'owner set'); is($clone->{reference}, '/bare', 'reference detected'); is($clone->{description}, "we're all clones", 'description read'); ok(my $bare = $manifest->{'/bare'}, '/bare in manifest'); @@ -88,7 +88,8 @@ SKIP: { open $fh, '>', "$alt/description" or die; print $fh "we're all clones\n" or die; close $fh or die; - is(xsys('git', "--git-dir=$alt", qw(config gitweb.owner lorelei)), 0, + is(xsys('git', "--git-dir=$alt", qw(config gitweb.owner), + "lorelei \xc4\x80"), 0, 'set gitweb user'); ok(unlink("$bare->{git_dir}/description"), 'removed bare/description'); open $fh, '>', $cfgfile or die; -- cgit v1.2.3-24-ge0c7