From 6b071c721412bc1c8e3fae7d85b22bd5f87ca9fb Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 24 Nov 2019 00:22:22 +0000 Subject: tests: use strict everywhere The "strict" pragma makes code easier to debug, and we had undeclared variables as a result in t/watch_maildir_v2.t. So use it everywhere to be consistent with the rest of our code. --- t/watch_maildir_v2.t | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 't/watch_maildir_v2.t') diff --git a/t/watch_maildir_v2.t b/t/watch_maildir_v2.t index 7fe23521..e0e8a13f 100644 --- a/t/watch_maildir_v2.t +++ b/t/watch_maildir_v2.t @@ -1,5 +1,6 @@ # Copyright (C) 2018-2019 all contributors # License: AGPL-3.0+ +use strict; use Test::More; use File::Temp qw/tempdir/; use PublicInbox::MIME; @@ -106,7 +107,7 @@ More majordomo info at http://vger.kernel.org/majordomo-info.html\n); local $SIG{__WARN__} = sub {}; # quiet spam check warning PublicInbox::WatchMaildir->new($config)->scan('full'); } - ($nr, $msgs) = $srch->reopen->query(''); + my ($nr, $msgs) = $srch->reopen->query(''); is($nr, 0, 'inbox is still empty'); is(unlink(glob("$maildir/new/*")), 1); } @@ -119,7 +120,7 @@ More majordomo info at http://vger.kernel.org/majordomo-info.html\n); PublicInbox::Emergency->new($maildir)->prepare(\$msg); $config->{'publicinboxwatch.spamcheck'} = 'spamc'; PublicInbox::WatchMaildir->new($config)->scan('full'); - ($nr, $msgs) = $srch->reopen->query(''); + my ($nr, $msgs) = $srch->reopen->query(''); is($nr, 1, 'inbox has one mail after spamc OK-ed a message'); my $mref = $ibx->msg_by_smsg($msgs->[0]); like($$mref, qr/something\n\z/s, 'message scrubbed on import'); @@ -132,7 +133,7 @@ More majordomo info at http://vger.kernel.org/majordomo-info.html\n); $msg = eval { local $/; <$fh> }; PublicInbox::Emergency->new($maildir)->prepare(\$msg); PublicInbox::WatchMaildir->new($config)->scan('full'); - ($nr, $msgs) = $srch->reopen->query('dfpost:6e006fd7'); + my ($nr, $msgs) = $srch->reopen->query('dfpost:6e006fd7'); is($nr, 1, 'diff postimage found'); my $post = $msgs->[0]; ($nr, $msgs) = $srch->query('dfpre:090d998b6c2c'); -- cgit v1.2.3-24-ge0c7