From b61b55643c617403f8d141cfe9bff22ad47913f7 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 26 Aug 2020 08:17:40 +0000 Subject: over: recent: remove expensive COUNT query As noted in commit 87dca6d8d5988c5eb54019cca342450b0b7dd6b7 ("www: rework query responses to avoid COUNT in SQLite"), COUNT on many rows is expensive on big SQLite DBs. We've already stopped using that code path long ago in WWW while -imapd and -nntpd never used it. So we'll adjust our remaining test cases to not need it, either. --- t/v2writable.t | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 't/v2writable.t') diff --git a/t/v2writable.t b/t/v2writable.t index 2bd7a400..9e4547ba 100644 --- a/t/v2writable.t +++ b/t/v2writable.t @@ -120,7 +120,9 @@ if ('ensure git configs are correct') { $mime->header_set('References', ''); ok($im->add($mime), 'message with multiple Message-ID'); $im->done; - my ($total, undef) = $ibx->over->recent; + my $total = $ibx->over->dbh->selectrow_array(<<''); +SELECT COUNT(*) FROM over WHERE num > 0 + is($ibx->mm->num_highwater, $total, 'got expected highwater value'); my $srch = $ibx->search; my $mset1 = $srch->reopen->query('m:abcde@1', { mset => 1 }); -- cgit v1.2.3-24-ge0c7