From 23a4e44bedabe5b8b651346cabc2a870c5377a30 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 25 May 2016 01:44:46 +0000 Subject: remove Email::Address dependency git has stricter requirements for ident names (no '<>') which Email::Address allows. Even in 1.908, Email::Address also has an incomplete fix for CVE-2015-7686 with a DoS-able regexp for comments. Since we don't care for or need all the RFC compliance of Email::Address, avoiding it entirely may be preferable. Email::Address will still be installed as a requirement for Email::MIME, but it is only used by the Email::MIME::header_str_set which we do not use --- t/mda.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 't/mda.t') diff --git a/t/mda.t b/t/mda.t index ad6a0913..fdba9672 100644 --- a/t/mda.t +++ b/t/mda.t @@ -48,6 +48,7 @@ my $mime; local $ENV{GIT_COMMITTER_NAME} = eval { use PublicInbox::MDA; + use PublicInbox::Address; use Encode qw/encode/; my $mbox = 't/utf8.mbox'; open(my $fh, '<', $mbox) or die "failed to open mbox: $mbox\n"; @@ -57,10 +58,9 @@ local $ENV{GIT_COMMITTER_NAME} = eval { $msg = Email::MIME->new($msg->simple->as_string); my $from = $msg->header('From'); - my @from = Email::Address->parse($from); - my $author = $from[0]->name; - my $email = $from[0]->address; - my $date = $msg ->header('Date'); + my $author = PublicInbox::Address::from_name($from); + my ($email) = PublicInbox::Address::emails($from); + my $date = $msg->header('Date'); is('Eléanor', encode('us-ascii', my $tmp = $author, Encode::HTMLCREF), -- cgit v1.2.3-24-ge0c7