From 95e5b6c343c45bb303db67fe7eb77e395c031e8d Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 18 Apr 2020 03:38:48 +0000 Subject: inbox: don't memoize missing description|cloneurl It's probably common to have inboxes initially setup without these files properly configured, so don't memoize at that stage. --- t/inbox.t | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 't/inbox.t') diff --git a/t/inbox.t b/t/inbox.t index 5f86440d..b59d5dba 100644 --- a/t/inbox.t +++ b/t/inbox.t @@ -4,12 +4,31 @@ use strict; use warnings; use Test::More; use_ok 'PublicInbox::Inbox'; +use File::Temp 0.19 (); my $x = PublicInbox::Inbox->new({url => [ '//example.com/test/' ]}); is($x->base_url, 'https://example.com/test/', 'expanded protocol-relative'); $x = PublicInbox::Inbox->new({url => [ 'http://example.com/test' ]}); is($x->base_url, 'http://example.com/test/', 'added trailing slash'); $x = PublicInbox::Inbox->new({}); + is($x->base_url, undef, 'undef base_url allowed'); +my $tmpdir = File::Temp->newdir('pi-inbox-XXXXXX', TMPDIR => 1); +$x->{inboxdir} = $tmpdir->dirname; +is_deeply($x->cloneurl, [], 'no cloneurls'); +is($x->description, '($INBOX_DIR/description missing)', 'default description'); +{ + open my $fh, '>', "$x->{inboxdir}/cloneurl" or die; + print $fh "https://example.com/inbox\n" or die; + close $fh or die; + open $fh, '>', "$x->{inboxdir}/description" or die; + print $fh "blah\n" or die; + close $fh or die; +} +is_deeply($x->cloneurl, ['https://example.com/inbox'], 'cloneurls update'); +is($x->description, 'blah', 'description updated'); +is(unlink(glob("$x->{inboxdir}/*")), 2, 'unlinked cloneurl & description'); +is_deeply($x->cloneurl, ['https://example.com/inbox'], 'cloneurls memoized'); +is($x->description, 'blah', 'description memoized'); done_testing(); -- cgit v1.2.3-24-ge0c7