From e876cd472939c009a0d6bce3cee25d98b0940928 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 5 Mar 2016 20:53:25 +0000 Subject: httpd: remove unnecessary eval We have per-middleware evals to deal with them being missing; no need to put an eval around the whole thing and use an extra level of indentation. --- script/public-inbox-httpd | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) (limited to 'script') diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd index b6c4e677..e7ed3c9d 100755 --- a/script/public-inbox-httpd +++ b/script/public-inbox-httpd @@ -23,28 +23,26 @@ my $refresh = sub { require PublicInbox::WWW; PublicInbox::WWW->preload; my $www = PublicInbox::WWW->new; - $app = eval { - builder { - enable 'Chunked'; - eval { - enable 'Deflater', - content_type => [ qw( - text/html - text/plain - application/atom+xml - )] - }; - $@ and warn + $app = builder { + enable 'Chunked'; + eval { + enable 'Deflater', + content_type => [ qw( + text/html + text/plain + application/atom+xml + )] + }; + $@ and warn "Plack::Middleware::Deflater missing, bandwidth will be wasted\n"; - eval { enable 'ReverseProxy' }; - $@ and warn + eval { enable 'ReverseProxy' }; + $@ and warn "Plack::Middleware::ReverseProxy missing,\n", "URL generation for redirects may be wrong if behind a reverse proxy\n"; - enable 'Head'; - sub { $www->call(@_) }; - }; + enable 'Head'; + sub { $www->call(@_) }; }; } }; -- cgit v1.2.3-24-ge0c7