From 9d6468d9560b8cd26ba2529d7a09a93ec5ad8c00 Mon Sep 17 00:00:00 2001 From: "Eric Wong (Contractor, The Linux Foundation)" Date: Thu, 5 Apr 2018 21:45:27 +0000 Subject: over: use only supported and safe SQLite APIs Some of this jankiness was from early performance problems and they turned out to be unnecessary measures. --- script/public-inbox-compact | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'script') diff --git a/script/public-inbox-compact b/script/public-inbox-compact index b8aaa4bd..43e94609 100755 --- a/script/public-inbox-compact +++ b/script/public-inbox-compact @@ -36,15 +36,12 @@ sub commit_changes ($$$) { my ($im, $old, $new) = @_; my @st = stat($old) or die "failed to stat($old): $!\n"; - for my $suf (qw(.pipe.lock -journal)) { - my $orig = "$old/over.sqlite3$suf"; - link($orig, "$new/over.sqlite3$suf") and next; - next if $!{ENOENT}; - die "failed to link $orig => $new/over.sqlite3$suf: $!\n"; + my $over = "$old/over.sqlite3"; + if (-f $over) { + require PublicInbox::Over; + $over = PublicInbox::Over->new($over); + $over->connect->sqlite_backup_to_file("$new/over.sqlite3"); } - link("$old/over.sqlite3", "$new/over.sqlite3") or die - "failed to link {$old => $new}/over.sqlite3: $!\n"; - rename($old, "$new/old") or die "rename $old => $new/old: $!\n"; chmod($st[2] & 07777, $new) or die "chmod $old: $!\n"; rename($new, $old) or die "rename $new => $old: $!\n"; -- cgit v1.2.3-24-ge0c7