From a479b45117ed69d9311770fa39e6676d38f9cab2 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 18 Apr 2020 03:38:50 +0000 Subject: favor `do {}' over `eval {}' for localized slurp I did not know to use the return value of `do' back in the day. There's probably no practical difference in these cases, but `eval' is overkill for these uses and may hide actual errors. We can get rid of a few redundant `scalar' ops and pass scalar refs to Email::MIME->new to avoid copies in a few more places, too. --- script/public-inbox-purge | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'script/public-inbox-purge') diff --git a/script/public-inbox-purge b/script/public-inbox-purge index c9b69c3d..8301b06d 100755 --- a/script/public-inbox-purge +++ b/script/public-inbox-purge @@ -21,7 +21,7 @@ GetOptions($opt, @PublicInbox::AdminEdit::OPT) or my @ibxs = PublicInbox::Admin::resolve_inboxes(\@ARGV, $opt); PublicInbox::AdminEdit::check_editable(\@ibxs); -my $data = do { local $/; scalar }; +my $data = do { local $/; }; $data =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s; my $n_purged = 0; -- cgit v1.2.3-24-ge0c7