From 999e8c1b3d54f4504cd4fa87949a077da325a1af Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 26 Jul 2020 09:03:15 +0000 Subject: t/init.t: don't modify ~/.public-inbox/ Tests for failures should not leave junk temporary files lying around in a users' ~/.public-inbox/. On a side note, I'm not sure if PI_DIR is or was ever necessary. It's never been documented, so perhaps using $HOME for this is better... --- script/public-inbox-init | 2 ++ 1 file changed, 2 insertions(+) (limited to 'script/public-inbox-init') diff --git a/script/public-inbox-init b/script/public-inbox-init index 951338af..b8d71f35 100755 --- a/script/public-inbox-init +++ b/script/public-inbox-init @@ -53,6 +53,7 @@ PublicInbox::Lock::lock_acquire($lock_obj); # git-config will operate on this (and rename on success): my ($fh, $pi_config_tmp) = tempfile('pi-init-XXXXXXXX', DIR => $dir); +my $cfg_tmp = UnlinkMe->new($pi_config_tmp); # Now, we grab another lock to use git-config(1) locking, so it won't # wait on the lock, unlike some of our internal flock()-based locks. @@ -176,6 +177,7 @@ if (defined $perm) { rename $pi_config_tmp, $pi_config or die "failed to rename `$pi_config_tmp' to `$pi_config': $!\n"; +delete $cfg_tmp->{file}; $auto_unlink->DESTROY; package UnlinkMe; -- cgit v1.2.3-24-ge0c7