From de2598aaab55155334f06a74a44e9c615914a4d9 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 30 Apr 2014 00:16:55 +0000 Subject: favor "--git-dir=..." over "--git-dir ..." This might improve grep-ability slightly and reduce allocations while we're at it. --- lib/PublicInbox/GitCatFile.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/GitCatFile.pm b/lib/PublicInbox/GitCatFile.pm index bdad2b56..b3d9bfb7 100644 --- a/lib/PublicInbox/GitCatFile.pm +++ b/lib/PublicInbox/GitCatFile.pm @@ -17,8 +17,8 @@ sub _cat_file_begin { my ($self) = @_; return if $self->{pid}; my ($in, $out); - my $pid = open2($in, $out, 'git', '--git-dir', $self->{git_dir}, - 'cat-file', '--batch'); + my $pid = open2($in, $out, 'git', "--git-dir=$self->{git_dir}", + qw(cat-file --batch)); $self->{pid} = $pid; $self->{in} = $in; -- cgit v1.2.3-24-ge0c7