From d9732203aa53d1fd7b3ba5fae415d3ac003937a0 Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Sat, 6 Aug 2016 01:58:47 +0000
Subject: mbox: be fair to other HTTP clients

At least for public-inbox-httpd, this allows us to avoid having
a client monopolize one event loop tick of the server for too
long.  It hurts throughput for the /all.mbox.gz endpoint, but I
doubt anybody cares and the latency improvement for other
clients would be appreciated.

We already do the same fairness thing for HTML pages.
---
 lib/PublicInbox/Mbox.pm | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'lib')

diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index 1e3de5b0..dc41548b 100644
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -138,6 +138,9 @@ sub getline {
 				${$self->{buf}} = '';
 				return $ret;
 			}
+
+			# be fair to other clients on public-inbox-httpd:
+			return '';
 		}
 		$res = $self->{cb}->($self->{opts});
 		$self->{msgs} = $res->{msgs};
-- 
cgit v1.2.3-24-ge0c7