From b6505664ee76dd3b49cca3d1f55e4e5e602ffbde Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 17 Jan 2021 07:09:56 +0000 Subject: initialize scalar for `vec' perlop modification Older Perls (tested 5.16.3) would warn on uninitialized scalars while newer (tested 5.28.1) do not. Just initialize it to an empty string since it'll be filled in by `vec'. --- lib/PublicInbox/LEI.pm | 2 +- lib/PublicInbox/Syscall.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 1f4a3082..2784ca6b 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -670,7 +670,7 @@ sub accept_dispatch { # Listener {post_accept} callback my ($sock) = @_; # ignore other $sock->autoflush(1); my $self = bless { sock => $sock }, __PACKAGE__; - vec(my $rvec, fileno($sock), 1) = 1; + vec(my $rvec = '', fileno($sock), 1) = 1; select($rvec, undef, undef, 1) or return send($sock, 'timed out waiting to recv FDs', MSG_EOR); my @fds = $recv_cmd->($sock, my $buf, 4096 * 33); # >MAX_ARG_STRLEN diff --git a/lib/PublicInbox/Syscall.pm b/lib/PublicInbox/Syscall.pm index a1f53235..5ff1d65f 100644 --- a/lib/PublicInbox/Syscall.pm +++ b/lib/PublicInbox/Syscall.pm @@ -224,7 +224,7 @@ sub epoll_ctl_mod8 { # epoll_wait wrapper # ARGS: (epfd, maxevents, timeout (milliseconds), arrayref) # arrayref: values modified to be [$fd, $event] -our $epoll_wait_events; +our $epoll_wait_events = ''; our $epoll_wait_size = 0; sub epoll_wait_mod4 { my ($epfd, $maxevents, $timeout_msec, $events) = @_; -- cgit v1.2.3-24-ge0c7