From b41c5982647a8ecccbadf159381840d74d36248a Mon Sep 17 00:00:00 2001 From: "Eric Wong (Contractor, The Linux Foundation)" Date: Thu, 22 Mar 2018 00:12:25 +0000 Subject: fix syntax warnings I keep forgetting to run "make syntax" --- lib/PublicInbox/Daemon.pm | 2 +- lib/PublicInbox/EvCleanup.pm | 4 +++- lib/PublicInbox/Inbox.pm | 2 +- lib/PublicInbox/SearchMsg.pm | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm index 9d27d2be..4629aadb 100644 --- a/lib/PublicInbox/Daemon.pm +++ b/lib/PublicInbox/Daemon.pm @@ -460,7 +460,7 @@ sub daemon_loop ($$) { @listeners = map { PublicInbox::Listener->new($_, $post_accept) } @listeners; - $PublicInbox::EvCleanup::ENABLED = 1; + PublicInbox::EvCleanup::enable(); Danga::Socket->EventLoop; $parent_pipe = undef; } diff --git a/lib/PublicInbox/EvCleanup.pm b/lib/PublicInbox/EvCleanup.pm index 384efd3d..1a3a3d5e 100644 --- a/lib/PublicInbox/EvCleanup.pm +++ b/lib/PublicInbox/EvCleanup.pm @@ -8,7 +8,9 @@ use warnings; use base qw(Danga::Socket); use fields qw(rd); -our $ENABLED; +my $ENABLED; +sub enabled { $ENABLED } +sub enable { $ENABLED = 1 } my $singleton; my $asapq = [ [], undef ]; my $nextq = [ [], undef ]; diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index f3070383..666c81d7 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -29,7 +29,7 @@ sub cleanup_task () { sub _cleanup_later ($) { my ($self) = @_; - return unless $PublicInbox::EvCleanup::ENABLED; + return unless PublicInbox::EvCleanup::enabled(); $cleanup_timer ||= PublicInbox::EvCleanup::later(*cleanup_task); $CLEANUP->{"$self"} = $self; } diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm index de1fd131..dd3d58d0 100644 --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -62,7 +62,7 @@ sub load_doc { sub bytes ($) { get_val($_[0]->{doc}, &PublicInbox::Search::BYTES) } sub lines ($) { get_val($_[0]->{doc}, &PublicInbox::Search::LINES) } sub num ($) { - $_[0]->{num} ||= get_val($_[0]->{doc}, PublicInbox::Search::NUM) + $_[0]->{num} ||= get_val($_[0]->{doc}, PublicInbox::Search::NUM()) } sub __hdr ($$) { -- cgit v1.2.3-24-ge0c7