From ae2891b12c078682e52c1c2d60482453e0e10095 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 28 Aug 2014 04:57:30 +0000 Subject: view: trim git patches delimited by /^---$/ Patches are usually better viewed standalone and are difficult to judge when nested. So save precious vertical space in our message index. --- lib/PublicInbox/View.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 27943391..23cb369b 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -81,6 +81,7 @@ sub index_entry { my ($part) = @_; return if $part->subparts; # walk_parts already recurses my $enc = enc_for($part->content_type) || $enc_msg || $enc_utf8; + my $more = ''; if ($part_nr > 0) { my $fn = $part->filename; @@ -96,13 +97,19 @@ sub index_entry { # Drop signatures $s =~ s/\n*-- \n.*\z//s; + # drop the remainder of git patches, they're usually better + # to review when the full message is viewed + if ($s =~ s/\n*---\n.*\z//s) { + $more = "$pfx...\n"; + } + # kill any trailing whitespace $s =~ s/\s+\z//s; # add prefix: $s =~ s/^/$pfx/sgm; - $rv .= $s . "\n"; + $rv .= $s . "\n$more"; ++$part_nr; }); -- cgit v1.2.3-24-ge0c7